[2.2] Use PropertyAccess component #1128

Closed
wants to merge 3 commits into
from

3 participants

@wouterj

This bundles uses the Symfony\Component\Form\Util\PropertyPath class. This is moved to its own component in Symfony2.2. You should use the Symfony\Component\PropertyAccess\PropertyPath class now and require the symfony/property-access packages.

The reason why I didn't create a PR is because you don't have a special branch for 2.2 yet?

@sstok

@WouterJ Actually you can just add the component as a dependency and start changing the namespace use's.
The PropertyAccess has no dependency on other components so it should give no conflicts.

Only problem, might be type hints. Unless that is true, there is no problem :)

@wouterj

@sstok thanks for waking me up, I see that we have a 2.2 branch now, so I'm going to start working on this!

@sstok

👍

@wouterj

I've changed all deprecated calls to the PropertyPath class and also fixed #1149

I can't test it, because there is some error with dependencies.

@sstok

You need to set jms/translation-bundle to >=1.1-dev

As composer is not configured with a minimum-stability it only installs 1.0 which is not compatible with symfony 2.2

@rande rande commented on the diff Mar 7, 2013
composer.json
@@ -25,6 +25,7 @@
"symfony/config": ">=2.2,<2.3-dev",
"symfony/console": ">=2.2,<2.3-dev",
"symfony/twig-bridge": ">=2.2,<2.3-dev",
+ "symfony/property-access": ">=2.2-dev",
@rande
Sonata Project member
rande added a line comment Mar 7, 2013

Can you flag the stable release ?

@stof
stof added a line comment Mar 7, 2013

it should at last be ~2.2 to have an upper bound

@wouterj
wouterj added a line comment Mar 7, 2013

@rande do you think it should be >=2.2,<2.3-dev, or do you want to use ~2.2 (thanks @stof)?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
@wouterj

@sstok thank you! I've run the tests and fixed an error. Should I create a PR which updates the JMSTranslationBundle to flag it with @dev?

@rande
Sonata Project member

cherry picked !

@rande rande closed this Mar 27, 2013
@wouterj

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment