Update deleteAction method in CRUDController #1176

Closed
wants to merge 1 commit into
from

Conversation

Projects
None yet
3 participants
Contributor

vincenttouzet commented Feb 16, 2013

Change method from DELETE to POST in deleteAction.

@vincenttouzet vincenttouzet Update Controller/CRUDController.php
Change method from DELETE to POST in deleteAction
7489dea

dao commented Feb 16, 2013

Unnecessary, delete and put are still valid if you enable with new static method on Request class (see docs)

Contributor

vincenttouzet commented Feb 17, 2013

Then why not requiring a PUT method for the createAction ?

Owner

rande commented Feb 17, 2013

The issue is only for Symfony2.2. And there is a new static method on the Request object to check if we have to deal with a POST or a PUT.

For now, the master branch is for symfony2.1

Contributor

vincenttouzet commented Feb 18, 2013

Ok so this pull request is not necessary

Owner

rande commented Feb 18, 2013

you can create a PR to handle the case where Request::getHttpMethodParameterOverride is enabled or not on the develop branch.

https://github.com/symfony/symfony/blob/2.2/src/Symfony/Component/HttpFoundation/Request.php#L604-L607

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment