Fixed undefined variable in base_show.html.twig #4527
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
greg0ire
approved these changes
Jun 23, 2017
|
Can we please get this tagged as a release? Thanks |
|
I requested it |
|
This one is released in 3.20.1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I am targeting this branch, because this bug was introduced there.
Closes #4525
Changelog
Subject
#4028 introduced bug in base_show.html.twig. This Pull Request will fix that bug.
In the CRUD/base_show.html.twig view on line 47, the variable
namewas replaced withview_group. However, this should have beenshow_tab(see start of loop on line 43).