[WIP] Added support for doctrine annotations #5284
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kunicmarko20
reviewed
Nov 2, 2018
| @@ -173,3 +178,22 @@ private function generateFallback($name) | |||
| } | |||
| } | |||
| } | |||
|
|
|||
| // NEXT_MAJOR: Remove this hack together with DiExtraBundle | |||
There was a problem hiding this comment.
you should add deprecations
kunicmarko20
reviewed
Nov 2, 2018
| use Symfony\Component\Finder\Finder; | ||
| use Symfony\Component\Finder\SplFileInfo; | ||
|
|
||
| final class AutoRegisterCompilerPass implements CompilerPassInterface |
There was a problem hiding this comment.
code here looks familiar 😄
kunicmarko20
reviewed
Nov 2, 2018
| } | ||
|
|
||
| @trigger_error( | ||
| 'Automatic registration of annotations is deprecated since 3.14, to be removed in 4.0.', |
There was a problem hiding this comment.
maybe now mention that doctrine should be used
OskarStark
requested changes
Nov 2, 2018
| * group="myGroup", | ||
| * label="myLabel", | ||
| * showInDashboard=true, | ||
| * translationDomain="AppBundle", |
There was a problem hiding this comment.
This should match the namespace of the example
| * showInDashboard=true, | ||
| * translationDomain="AppBundle", | ||
| * pagerType="", | ||
| * persistFilters="", |
| * ) | ||
| */ | ||
| class MyAdmin extends AbstractAdmin | ||
| { |
There was a problem hiding this comment.
Please add „// ...“ to make clear this class is not empty
| Annotations using doctrine | ||
| ========================== | ||
|
|
||
| All annotations require doctrine/annotations, it can easily be installed by composer: |
|
|
||
| final class AutoRegisterCompilerPass implements CompilerPassInterface | ||
| { | ||
| const DEFAULT_SERVICE_PREFIX = 'app.admin.'; |
There was a problem hiding this comment.
There is one usage for it, so yes
|
Any news here @core23 ? |
|
Could you please rebase your PR and fix merge conflicts? |
Merged
|
Closing this in favor of @kunicmarko20 bundles |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I am targeting this branch, because {reason}.
Changelog
To do
Subject
The DiExtraBundle has no support for symfony 4 and looks abandoned. This PR will use
doctrine/annotationsto add support for all symfony versions.