Skip to content

[WIP] gracefully handle the absence of the debug.stopwatch service #61

Merged
merged 1 commit into from May 7, 2013

4 participants

@lsmith77
lsmith77 commented May 7, 2013

attempt to fix #60

@rande
Sonata Project member
rande commented May 7, 2013

Not sure it is the real solution. The traceable service must be only used on debug mode.

@lsmith77
lsmith77 commented May 7, 2013

@rande the proper thing would be a compiler pass to determine if the profiler is enabled but this seems a bit like overkill which is why i am proposing this solution.

@rande rande merged commit 26300bd into master May 7, 2013

1 check passed

Details default The Travis build passed
@Soullivaneuh
Sonata Project member

Can you push a new stable version for this PR ? I'm still stuck in production...

Thanks ! :)

@KingCrunch

@lsmith77 If I get this right, than a CompilerPass is only applied during compiling (of course :wink:) which is only once (at least in production). Why is this overkill?

@KingCrunch KingCrunch referenced this pull request in symfony-cmf/block-bundle May 18, 2013
Closed

Loose version restriction on sonata-block-bundle #59

@lsmith77

its overkill in terms of development and maintenance effort not in terms of performance :)

@lsmith77 lsmith77 deleted the debug_stopwatch branch May 18, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.