[WIP] gracefully handle the absence of the debug.stopwatch service #61

Merged
merged 1 commit into from May 7, 2013

Conversation

Projects
None yet
4 participants
@lsmith77
Collaborator

lsmith77 commented May 7, 2013

attempt to fix #60

@rande

This comment has been minimized.

Show comment
Hide comment
@rande

rande May 7, 2013

Member

Not sure it is the real solution. The traceable service must be only used on debug mode.

Member

rande commented May 7, 2013

Not sure it is the real solution. The traceable service must be only used on debug mode.

@lsmith77

This comment has been minimized.

Show comment
Hide comment
@lsmith77

lsmith77 May 7, 2013

Collaborator

@rande the proper thing would be a compiler pass to determine if the profiler is enabled but this seems a bit like overkill which is why i am proposing this solution.

Collaborator

lsmith77 commented May 7, 2013

@rande the proper thing would be a compiler pass to determine if the profiler is enabled but this seems a bit like overkill which is why i am proposing this solution.

rande added a commit that referenced this pull request May 7, 2013

Merge pull request #61 from sonata-project/debug_stopwatch
[WIP] gracefully handle the absence of the debug.stopwatch service

@rande rande merged commit 26300bd into master May 7, 2013

1 check passed

default The Travis build passed
Details
@Soullivaneuh

This comment has been minimized.

Show comment
Hide comment
@Soullivaneuh

Soullivaneuh May 10, 2013

Member

Can you push a new stable version for this PR ? I'm still stuck in production...

Thanks ! :)

Member

Soullivaneuh commented May 10, 2013

Can you push a new stable version for this PR ? I'm still stuck in production...

Thanks ! :)

@KingCrunch

This comment has been minimized.

Show comment
Hide comment
@KingCrunch

KingCrunch May 18, 2013

@lsmith77 If I get this right, than a CompilerPass is only applied during compiling (of course 😉) which is only once (at least in production). Why is this overkill?

@lsmith77 If I get this right, than a CompilerPass is only applied during compiling (of course 😉) which is only once (at least in production). Why is this overkill?

@KingCrunch KingCrunch referenced this pull request in symfony-cmf/block-bundle May 18, 2013

Closed

Loose version restriction on sonata-block-bundle #59

@lsmith77

This comment has been minimized.

Show comment
Hide comment
@lsmith77

lsmith77 May 18, 2013

Collaborator

its overkill in terms of development and maintenance effort not in terms of performance :)

Collaborator

lsmith77 commented May 18, 2013

its overkill in terms of development and maintenance effort not in terms of performance :)

@lsmith77 lsmith77 deleted the debug_stopwatch branch May 18, 2013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment