From 38ba7ce0fc6659015fe9b78194908341d37fb1d5 Mon Sep 17 00:00:00 2001 From: Sonata CI Date: Sun, 29 Aug 2021 09:37:53 +0100 Subject: [PATCH] DevKit updates (#646) --- .github/FUNDING.yml | 2 +- .github/workflows/test.yaml | 4 ++-- CONTRIBUTING.md | 4 ++-- Makefile | 8 ++++---- 4 files changed, 9 insertions(+), 9 deletions(-) diff --git a/.github/FUNDING.yml b/.github/FUNDING.yml index dd14c71b..db9a8a36 100644 --- a/.github/FUNDING.yml +++ b/.github/FUNDING.yml @@ -2,4 +2,4 @@ # # It's auto-generated by sonata-project/dev-kit package. -github: [OskarStark, core23, VincentLanglet, wbloszyk] +github: [VincentLanglet, greg0ire, OskarStark, core23] diff --git a/.github/workflows/test.yaml b/.github/workflows/test.yaml index 66ce71ee..288b5dda 100644 --- a/.github/workflows/test.yaml +++ b/.github/workflows/test.yaml @@ -83,8 +83,8 @@ jobs: dependency-versions: "${{ matrix.dependencies }}" composer-options: "--prefer-dist --prefer-stable" - - name: Run Tests - run: make test + - name: Run Tests with coverage + run: make coverage - name: Send coverage to Codecov uses: codecov/codecov-action@v1 diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md index 5d1b14aa..061f43a6 100644 --- a/CONTRIBUTING.md +++ b/CONTRIBUTING.md @@ -358,8 +358,8 @@ If you want to change some dependencies, here are the rules: - Lower version dropping is accepted as a Backward Compatible change according to [semver][semver_dependencies_update], but some extra rules MUST be respected here: - PHP versions that are under the [orange zone][php_supported_versions] (Security Support) **MUST NOT** be dropped on the stable branch. - - PHP versions that are under the [green zone][php_supported_versions] (Active Support) **MUST NOT** be dropped on the master branch. - - If it's a Symfony package, at least the last LTS version **MUST** be supported, even on master. + - PHP versions that are under the [green zone][php_supported_versions] (Active Support) **MUST NOT** be dropped on the unstable branch. + - If it's a Symfony package, at least the last LTS version **MUST** be supported, even on the unstable branch. - Generally, don't drop dependency version if it doesn't have a big impact on the code. - Backward Compatible code related to the dropped version **MUST** be dropped on the same PR. This will allow seeing if this version drop **is really worth it** or not. diff --git a/Makefile b/Makefile index 48e23024..bf55c4bc 100644 --- a/Makefile +++ b/Makefile @@ -77,13 +77,13 @@ build: mkdir $@ test: -ifeq ($(shell php --modules|grep --quiet pcov;echo $$?), 0) - vendor/bin/simple-phpunit -c phpunit.xml.dist --coverage-clover build/logs/clover.xml -else vendor/bin/simple-phpunit -c phpunit.xml.dist -endif .PHONY: test +coverage: + vendor/bin/simple-phpunit -c phpunit.xml.dist --coverage-clover build/logs/clover.xml +.PHONY: coverage + docs: cd docs && sphinx-build -W -b dirhtml -d _build/doctrees . _build/html .PHONY: docs