Support filters with CONDITION_OR

[pascal-hofmann]

This PR adds support for StringFilters with CONDITION_OR. These are required for correct filtering in fields of type sonata_type_model_autocomplete with multiple properties.

Q	A
Bug fix?	yes
New feature?	no
BC breaks?	no
Deprecations?	no
Tests pass?	yes
Fixed tickets	-
License	MIT
Doc PR	-

[pascal-hofmann]

@rande @soullivaneuh @dunglas: Any plans on merging this PR?

[soullivaneuh]

From where CONDITION_OR will be from? I mean, with the interface.

Could you please rebase your PR to check CI?

[pascal-hofmann]

A CONDITION_OR will be used if you use a form field of type "sonata_type_model_autocomplete" and set "property" to an array of fields.

property: defaults to null. You have to set this to designate which field (or a list of fields) to use for the choice values. This value can be string or array of strings.

See https://sonata-project.org/bundles/admin/master/doc/reference/form_types.html#sonata-type-model-autocomplete

Without my changes, this generates a query where all conditions are combined with "AND", because the CONDITION_OR is silently ignored. So if you have an autocomplete and want the user to be able to search for either firstname or lastname, only items where both firstname and lastname match will be autocompleted.

[pascal-hofmann]

My PR is already based on the latest master - I'll try to close and reopen it to trigger CI checks.

[pascal-hofmann]

CI build randomly fails (see #153). CS issues are in existing code, and IMHO should be addressed in a commit separate from my changes.

[soullivaneuh]

I fixed CS on master, please rebase again.

[pascal-hofmann]

I rebased, but the CI build failed (see #153). Closing and reopening, maybe it'll work next time...

[pascal-hofmann]

@soullivaneuh The failing TravisCI checks relate to this issue: sonata-project/SonataAdminBundle#3150

[pascal-hofmann]

Closing and reopening to trigger ci checks.

[pascal-hofmann]

Hmpf. I thought the dependency on security-acl was fixed, but that was only on another pr.

[OskarStark]

@phofmann-trust you can rebase to get the latest travis conf

[pascal-hofmann]

Why rebase? On which branch? 😕

[OskarStark]

on the master branch

[pascal-hofmann]

Latest commit on master is from 14 Dec - I already did a rebase on this last year.

[OskarStark]

i restarted travis, lets see if its working...

[OskarStark]

@core can you please check travis? maybe here is something different? Oo

[OskarStark]

travis is green now after a restart

i will let @dbu merge this PR

[dbu]

oskar, i only maintain phpcr-odm, but not mongo odm.

[OskarStark]

@dbu sorry my fault

Am Sonntag, 14. Februar 2016 schrieb David Buchmann :

oskar, i only maintain phpcr-odm, but not mongo odm.

—
Reply to this email directly or view it on GitHub
#151 (comment)
.

[OskarStark]

tests are green, looks valid to me 👍

[OskarStark]

Thank you @phofmann-trust for your contribution!

[pascal-hofmann]

@OskarStark Thanks for merging. Awesome! 👍