Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

simplethings_entityaudit.reader dependency is mandatory or is breaking Admin with SonataPageBundle #266

Closed
Wharenn opened this issue Sep 3, 2013 · 3 comments

Comments

@Wharenn
Copy link

@Wharenn Wharenn commented Sep 3, 2013

When used with SonataAdmin and SonataPageBundle, the block creation page is broken when it tries to list all available block types. The sonata.admin_doctrine_orm.block.audit block service defined in audit.xml allows an invalid dependency on simplethings_entityaudit.reader service if the optional EntityAuditBundle is missing. But the constructor of the service class Sonata\DoctrineORMAdminBundle\Block\AuditBlockService does not allow a null value as 3rd parameter and throws an exception :

Catchable Fatal Error: Argument 3 passed to Sonata\DoctrineORMAdminBundle\Block\AuditBlockService::__construct() must be an instance of SimpleThings\EntityAudit\AuditReader, null given, called in /data/usr/local/apps/digiposte-php/current/php/cache/backend/dev/backendDevDebugProjectContainer.php on line 2967 and defined in /data/usr/local/apps/digiposte-php/current/php/vendor/sonata-project/doctrine-orm-admin-bundle/Sonata/DoctrineORMAdminBundle/Block/AuditBlockService.php line 40

@broncha
Copy link

@broncha broncha commented Oct 23, 2013

+1

1 similar comment
@ShachMaT
Copy link

@ShachMaT ShachMaT commented Nov 4, 2013

+1

@JulienBohy
Copy link

@JulienBohy JulienBohy commented Nov 4, 2013

same issue...

@rande rande closed this in e8c50c9 Nov 7, 2013
rande added a commit that referenced this issue Nov 7, 2013
Only load audit block if SimpleThingsEntityAuditBundle is available (Fixes #266)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
4 participants
You can’t perform that action at this time.