renamed GalleryHasMedia to GalleryItem #948

OskarStark · 2016-02-14T20:56:36Z

Fixes #828

Changelog

### Changed
- Renamed `GalleryHasMedia` to `GalleryItem` and all controllers, interfaces and actions accordingly
- Renamed `setGalleryHasMedias` to `setGalleryItems` in `Gallery`
- Renamed `getGalleryHasMedias` to `getGalleryItems` in `Gallery`
- Renamed `addGalleryHasMedias` to `addGalleryItem` in `Gallery`
- Renamed `$galleryHasMedias` to `$galleryItems` in `Gallery`
- Renamed `GalleryHasMediaAdmin` to `GalleryItemAdmin`
- Renamed `$galleryHasMediaClass` to `$galleryItemClass` in `GalleryController`
- Renamed `getGalleryGaleryhasmediasAction` to `getGalleryGalleryItemAction` in `GalleryController`
- Renamed `postGalleryMediaGalleryhasmediaAction` to `postGalleryMediaGalleryItemAction` in `GalleryController`
- Renamed `handleWriteGalleryhasmedia` to `handleWriteGalleryItem` in `GalleryController`
- Renamed `putGalleryMediaGalleryhasmediaAction` to `putGalleryMediaGalleryItemAction` in `GalleryController`
- Renamed `deleteGalleryMediaGalleryhasmediaAction` to `deleteGalleryMediaGalleryItemAction` in `GalleryController`
- Changed route name from `sonata_media_api_form_gallery_has_media ` to `sonata_media_api_form_gallery_item`
- Renamed `GalleryHasMediaInterface` to `GalleryItemInterface`
- Renamed config key from `gallery_has_media` to `gallery_item` under `sonata_media.class`
- Renamed `BaseGalleryHasMedia` to `BaseGalleryItem`
- Renamed `ApiGalleryHasMediaType` to `ApiGalleryItemType`
- Changed `GalleryInterface` and renamed `setGalleryHasMedias`, `getGalleryHasMedias` and `addGalleryHasMedias` to `setGalleryItems`, `getGalleryItems` and `addGalleryItem`
- Renamed `reorderGalleryHasMedia` to `reorderGalleryItems` in `BaseGallery`
- Renamed `BaseGalleryHasMediaRepository` to `BaseGalleryItemRepository`
- Renamed `GalleryHasMediaRepository` to `GalleryItemRepository`
- Renamed `form.type` alias from `sonata_media_api_form_gallery_has_media` to `sonata_media_api_form_gallery_item`
- Renamed PHP files, skeletons and schema XML's accordingly to their class/entity names
- Renamed `Resources/config/serializer/Model.GalleryHasMedia.xml` to `Resources/config/serializer/Model.GalleryItem.xml`
- Renamed `translation keys from `form.label_gallery_has_medias` to `form.label.gallery_items`
- Changed `Resources/views/Gallery/view.html.twig`

Subject

This change is to huge to keep it BC, so i will schedule this for the next major release.

@sonata-project/contributors please review this change, thank you!

OskarStark · 2016-05-12T15:20:18Z

Can we merge this in 3.1 ? @soullivaneuh

OskarStark · 2016-05-12T15:21:13Z

ping @greg0ire can you please review?

greg0ire · 2016-05-12T15:22:44Z

Block/GalleryBlockService.php

+                'title'   => $galleryItem->getMedia()->getName(),
+                'caption' => $galleryItem->getMedia()->getDescription(),
+                'type'    => $type,
+                'media'   => $galleryItem->getMedia(),


Didn't we stop aligning things?

i rebased, but this is old and should then be fixxed by Style CI IMO

mvhirsch · 2016-05-12T15:26:16Z

👍 for such a change, this will finally clarify what my $gallery->getGalleryHasMedias() (now $gallery->getGalleryItems()) is supposed to do

greg0ire · 2016-05-12T15:28:03Z

UPGRADE-3.0.md

+
+## GalleryHasMedia
+
+The `GalleryHasMedia` has been renamed to `GalleryItem`, please adjust your code and be sure to move your assets to the correct database table.


gqq on this line with vim

?? what do you mean? 😄

That it's too long. If you open the file with vim, and type 10Ggqq, it will be fixed :)

greg0ire · 2016-05-12T15:29:07Z

Huge refactoring indeed! Congrats!

soullivaneuh · 2016-05-12T15:32:01Z

Can we merge this in 3.1 ? @soullivaneuh

Yes after I push 3.0. But it has to be BC.

OskarStark · 2016-05-12T15:34:23Z

Yes after I push 3.0. But it has to be BC.

then lets merge it in 4.0, this is a massive change, all classes needs to be handeld...

And i thought, because 3 is a new major, we can introduce BC breaks

soullivaneuh · 2016-05-12T16:14:06Z

You rename the class GalleryHasMediaAdmin, why not simply keep it and mark it as deprecated?

OskarStark · 2016-05-13T10:58:25Z

Really? IMO we need to deprecate all (Api-)Controller classes too and maybe something else.

and i don't know what will happen if you upgrade and upgrade your schema, the new table name shouldn't match the new generated one, shouldn't it?

Wee need to keep the service name sonata.media.admin.gallery_has_media, too IMO

And the GalleryHasMediaAdmin, too

And the GalleryHasMediaInterface, too

soullivaneuh · 2016-05-26T20:52:57Z

According to the new Sonata version management and next major release plan, this project has been refactored regarding branching and versioning.

If you see this message, your PR concerns a patch or a minor release and is not targeting the right branch.

So I'm closing this one, but don't see it as a refusal. If you think your work is still relevant and want to continue, feel free to reopen it on the right branch (e.g. the default one).

Regards.

OskarStark · 2016-05-26T20:54:11Z

This is for the next major

greg0ire · 2016-06-08T08:16:12Z

Oh wait Travis has the same problems in fact : https://travis-ci.org/sonata-project/SonataMediaBundle/jobs/135807506#L623

greg0ire · 2016-06-08T08:18:30Z

So it must simply be that SonataCI is more strict --fail-on-warning config flag ? @rande @soullivaneuh

SonataCI · 2016-06-09T00:10:27Z

Could you please rebase your PR and fix merge conflicts?

OskarStark · 2016-06-09T07:29:21Z

rebased

SonataCI · 2016-06-12T12:50:25Z

Could you please rebase your PR and fix merge conflicts?

OskarStark · 2016-06-13T08:17:07Z

rebased again!

Can we please merge this?

greg0ire · 2016-06-13T08:25:03Z

Why is it marked as "in progress"?

OskarStark · 2016-06-13T08:27:12Z

oops, sorry

greg0ire · 2016-06-13T08:29:06Z

UPGRADE-4.0.md

+## Renamed GalleryHasMedia to GalleryItem
+
+All Actions, Controllers, Interfaces and anything related to this is renamed accordingly.
+>>>>>>> renamed GalleryHasMedia to GalleryItem


greg0ire · 2016-06-13T08:58:56Z

Thanks for the huge work @OskarStark !

OskarStark · 2016-06-13T09:30:49Z

Thanks for the huge work @OskarStark !

Thank you for your feedback @greg0ire 👍

core23 · 2016-07-23T07:43:31Z

@OskarStark Is there a reason why we kept Modeel.GalleryHasMedia.xml?

OskarStark · 2016-08-01T13:42:43Z

not really, did i forget it?

Renamed serializer/Model.GalleryHasMedia.xml to serializer/Model.GalleryItem.xml

core23 · 2016-08-01T14:25:06Z

The file still exists, I would say yes

OskarStark · 2016-08-01T14:34:10Z

I created a PR here: #1094

OskarStark added this to the 3.0 milestone Feb 14, 2016

OskarStark mentioned this pull request Feb 14, 2016

[DX] would like to rename the GalleryHasMedia object #828

Closed

OskarStark added the nice to have label Feb 15, 2016

SonataCI removed the nice to have label May 2, 2016

OskarStark added review required Needs: Changelog note Needs: Upgrade note labels May 12, 2016

greg0ire reviewed May 12, 2016
View reviewed changes

OskarStark removed this from the 3.0 milestone May 12, 2016

OskarStark removed Needs: Changelog note Needs: Upgrade note labels May 12, 2016

soullivaneuh closed this May 26, 2016

OskarStark reopened this May 26, 2016

OskarStark added pending author in progress labels May 26, 2016

SonataCI added pending author and removed pending author labels Jun 9, 2016

SonataCI added pending author and removed pending author labels Jun 12, 2016

OskarStark added the major label Jun 13, 2016

OskarStark removed the in progress label Jun 13, 2016

greg0ire reviewed Jun 13, 2016
View reviewed changes

renamed GalleryHasMedia to GalleryItem

8c3d4bf

greg0ire merged commit f7a6296 into sonata-project:master Jun 13, 2016

OskarStark deleted the rename branch June 13, 2016 09:30

OskarStark added RTM and removed review required RTM labels Jun 13, 2016

ksom pushed a commit to ksom/SonataMediaBundle that referenced this pull request Jun 27, 2016

renamed GalleryHasMedia to GalleryItem (sonata-project#948)

c59febf

OskarStark mentioned this pull request Aug 1, 2016

remove not used file Model.GalleryHasMedia.xml file #1094

Merged

phansys mentioned this pull request Aug 21, 2021

Backport GalleryItemInterface from master branch #2080

Closed

3 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

renamed GalleryHasMedia to GalleryItem #948

renamed GalleryHasMedia to GalleryItem #948

OskarStark commented Feb 14, 2016 •

edited

OskarStark commented May 12, 2016

OskarStark commented May 12, 2016

greg0ire May 12, 2016

OskarStark May 12, 2016

greg0ire May 12, 2016

OskarStark May 27, 2016

mvhirsch commented May 12, 2016

greg0ire May 12, 2016 •

edited

OskarStark May 12, 2016 •

edited

greg0ire May 12, 2016

greg0ire commented May 12, 2016

soullivaneuh commented May 12, 2016 •

edited by greg0ire

OskarStark commented May 12, 2016 •

edited

soullivaneuh commented May 12, 2016

OskarStark commented May 13, 2016 •

edited

soullivaneuh commented May 26, 2016

OskarStark commented May 26, 2016

greg0ire commented Jun 8, 2016

greg0ire commented Jun 8, 2016

SonataCI commented Jun 9, 2016

OskarStark commented Jun 9, 2016

SonataCI commented Jun 12, 2016

OskarStark commented Jun 13, 2016

greg0ire commented Jun 13, 2016

OskarStark commented Jun 13, 2016

greg0ire Jun 13, 2016 •

edited

OskarStark Jun 13, 2016

OskarStark Jun 13, 2016

greg0ire commented Jun 13, 2016

OskarStark commented Jun 13, 2016

core23 commented Jul 23, 2016

OskarStark commented Aug 1, 2016 •

edited

core23 commented Aug 1, 2016

OskarStark commented Aug 1, 2016 •

edited


		## GalleryHasMedia

		The `GalleryHasMedia` has been renamed to `GalleryItem`, please adjust your code and be sure to move your assets to the correct database table.

renamed GalleryHasMedia to GalleryItem #948

renamed GalleryHasMedia to GalleryItem #948

Conversation

OskarStark commented Feb 14, 2016 • edited

Changelog

Subject

OskarStark commented May 12, 2016

OskarStark commented May 12, 2016

greg0ire May 12, 2016

Choose a reason for hiding this comment

OskarStark May 12, 2016

Choose a reason for hiding this comment

greg0ire May 12, 2016

Choose a reason for hiding this comment

OskarStark May 27, 2016

Choose a reason for hiding this comment

mvhirsch commented May 12, 2016

greg0ire May 12, 2016 • edited

Choose a reason for hiding this comment

OskarStark May 12, 2016 • edited

Choose a reason for hiding this comment

greg0ire May 12, 2016

Choose a reason for hiding this comment

greg0ire commented May 12, 2016

soullivaneuh commented May 12, 2016 • edited by greg0ire

OskarStark commented May 12, 2016 • edited

soullivaneuh commented May 12, 2016

OskarStark commented May 13, 2016 • edited

soullivaneuh commented May 26, 2016

OskarStark commented May 26, 2016

greg0ire commented Jun 8, 2016

greg0ire commented Jun 8, 2016

SonataCI commented Jun 9, 2016

OskarStark commented Jun 9, 2016

SonataCI commented Jun 12, 2016

OskarStark commented Jun 13, 2016

greg0ire commented Jun 13, 2016

OskarStark commented Jun 13, 2016

greg0ire Jun 13, 2016 • edited

Choose a reason for hiding this comment

OskarStark Jun 13, 2016

Choose a reason for hiding this comment

OskarStark Jun 13, 2016

Choose a reason for hiding this comment

greg0ire commented Jun 13, 2016

OskarStark commented Jun 13, 2016

core23 commented Jul 23, 2016

OskarStark commented Aug 1, 2016 • edited

core23 commented Aug 1, 2016

OskarStark commented Aug 1, 2016 • edited

OskarStark commented Feb 14, 2016 •

edited

greg0ire May 12, 2016 •

edited

OskarStark May 12, 2016 •

edited

soullivaneuh commented May 12, 2016 •

edited by greg0ire

OskarStark commented May 12, 2016 •

edited

OskarStark commented May 13, 2016 •

edited

greg0ire Jun 13, 2016 •

edited

OskarStark commented Aug 1, 2016 •

edited

OskarStark commented Aug 1, 2016 •

edited