Public (API) controller services for FOSRest #1689
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @jeroendk, I submitted a PR to your repo some time ago jeroendk#1 fixing the tests |
|
@franmomu Wow sorry, did not see that! |
no worries! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because I am not able to move forward on #1654, I submit this separate pull request to fix the bug in the service definition. I Hope we can merge this one without adding functional tests.
For the route loader in the FOSRestBundle a (service) resource defined in a route needs to be public.
Otherwise, their route loader can't load the service.
I am targeting this branch because this is a bugfix and backwards compatible.
Closes #1652
### Fixed API routes config, made them public for the FOSRest routeloader.