Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase phpstan to max level #2013

Conversation

jordisala1991
Copy link
Member

@jordisala1991 jordisala1991 commented Jul 20, 2021

Subject

I am targeting this branch, because this is the only branch where it is safe to increase phpstan to max level.
This PR tries to set phpstan to max level, preparing the bundle to the next release.

src/Admin/BaseMediaAdmin.php Outdated Show resolved Hide resolved
src/Command/AddMassMediaCommand.php Show resolved Hide resolved
src/Command/AddMassMediaCommand.php Outdated Show resolved Hide resolved
@jordisala1991 jordisala1991 marked this pull request as ready for review July 23, 2021 16:10
@jordisala1991 jordisala1991 requested review from VincentLanglet and a team July 23, 2021 16:10
src/Provider/Pool.php Show resolved Hide resolved
src/Provider/Pool.php Show resolved Hide resolved
@jordisala1991 jordisala1991 merged commit ff3c6a2 into sonata-project:master Jul 26, 2021
@jordisala1991 jordisala1991 deleted the improvement/phpstan-max-level branch July 26, 2021 18:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants