Skip to content
This repository has been archived by the owner on Jul 28, 2022. It is now read-only.

Commit

Permalink
DevKit updates (#609)
Browse files Browse the repository at this point in the history
  • Loading branch information
SonataCI committed Aug 29, 2021
1 parent 530e4ad commit 3e4b31d
Show file tree
Hide file tree
Showing 4 changed files with 9 additions and 9 deletions.
2 changes: 1 addition & 1 deletion .github/FUNDING.yml
Expand Up @@ -2,4 +2,4 @@
#
# It's auto-generated by sonata-project/dev-kit package.

github: [OskarStark, core23, VincentLanglet, wbloszyk]
github: [core23, OskarStark, greg0ire, wbloszyk]
4 changes: 2 additions & 2 deletions .github/workflows/test.yaml
Expand Up @@ -71,8 +71,8 @@ jobs:
dependency-versions: "${{ matrix.dependencies }}"
composer-options: "--prefer-dist --prefer-stable"

- name: Run Tests
run: make test
- name: Run Tests with coverage
run: make coverage

- name: Send coverage to Codecov
uses: codecov/codecov-action@v1
Expand Down
4 changes: 2 additions & 2 deletions CONTRIBUTING.md
Expand Up @@ -358,8 +358,8 @@ If you want to change some dependencies, here are the rules:
- Lower version dropping is accepted as a Backward Compatible change according to [semver][semver_dependencies_update],
but some extra rules MUST be respected here:
- PHP versions that are under the [orange zone][php_supported_versions] (Security Support) **MUST NOT** be dropped on the stable branch.
- PHP versions that are under the [green zone][php_supported_versions] (Active Support) **MUST NOT** be dropped on the master branch.
- If it's a Symfony package, at least the last LTS version **MUST** be supported, even on master.
- PHP versions that are under the [green zone][php_supported_versions] (Active Support) **MUST NOT** be dropped on the unstable branch.
- If it's a Symfony package, at least the last LTS version **MUST** be supported, even on the unstable branch.
- Generally, don't drop dependency version if it doesn't have a big impact on the code.
- Backward Compatible code related to the dropped version **MUST** be dropped on the same PR.
This will allow seeing if this version drop **is really worth it** or not.
Expand Down
8 changes: 4 additions & 4 deletions Makefile
Expand Up @@ -77,13 +77,13 @@ build:
mkdir $@

test:
ifeq ($(shell php --modules|grep --quiet pcov;echo $$?), 0)
vendor/bin/simple-phpunit -c phpunit.xml.dist --coverage-clover build/logs/clover.xml
else
vendor/bin/simple-phpunit -c phpunit.xml.dist
endif
.PHONY: test

coverage:
vendor/bin/simple-phpunit -c phpunit.xml.dist --coverage-clover build/logs/clover.xml
.PHONY: coverage

docs:
cd docs && sphinx-build -W -b dirhtml -d _build/doctrees . _build/html
.PHONY: docs
Expand Down

0 comments on commit 3e4b31d

Please sign in to comment.