From 26cca9306da9c373bbb805fb967997e2b46a14f1 Mon Sep 17 00:00:00 2001 From: SonataCI Date: Tue, 14 Apr 2020 02:11:41 +0000 Subject: [PATCH 1/2] DevKit updates --- .php_cs.dist | 1 + 1 file changed, 1 insertion(+) diff --git a/.php_cs.dist b/.php_cs.dist index dd93021c..b890baa4 100644 --- a/.php_cs.dist +++ b/.php_cs.dist @@ -32,6 +32,7 @@ $rules = [ 'no_superfluous_phpdoc_tags' => ['allow_mixed' => true], 'no_useless_else' => true, 'no_useless_return' => true, + 'nullable_type_declaration_for_default_null_value' => ['use_nullable_type_declaration' => true], 'ordered_class_elements' => true, 'ordered_imports' => true, 'phpdoc_order' => true, From 4b59103fb53a3c8dbc309af849f9439917611345 Mon Sep 17 00:00:00 2001 From: Sullivan SENECHAL Date: Tue, 14 Apr 2020 04:12:04 +0200 Subject: [PATCH 2/2] Applied fixes from FlintCI --- src/Backend/PostponeRuntimeBackend.php | 2 +- src/Event/IterateEvent.php | 2 +- src/Model/Message.php | 8 ++++---- src/Model/MessageInterface.php | 8 ++++---- tests/Entity/MessageManagerMock.php | 2 +- 5 files changed, 11 insertions(+), 11 deletions(-) diff --git a/src/Backend/PostponeRuntimeBackend.php b/src/Backend/PostponeRuntimeBackend.php index 4aa2fb9b..1970c81a 100644 --- a/src/Backend/PostponeRuntimeBackend.php +++ b/src/Backend/PostponeRuntimeBackend.php @@ -74,7 +74,7 @@ public function publish(MessageInterface $message) * Actually, an event is not necessary, you can call this method manually, to. * The event is not processed in any way. */ - public function onEvent(Event $event = null) + public function onEvent(?Event $event = null) { while (!empty($this->messages)) { $message = array_shift($this->messages); diff --git a/src/Event/IterateEvent.php b/src/Event/IterateEvent.php index 429aad3c..4d10a547 100644 --- a/src/Event/IterateEvent.php +++ b/src/Event/IterateEvent.php @@ -46,7 +46,7 @@ class IterateEvent extends Event * @param BackendInterface $backend * @param MessageInterface $message */ - public function __construct(MessageIteratorInterface $iterator, BackendInterface $backend = null, MessageInterface $message = null) + public function __construct(MessageIteratorInterface $iterator, ?BackendInterface $backend = null, ?MessageInterface $message = null) { $this->iterator = $iterator; $this->backend = $backend; diff --git a/src/Model/Message.php b/src/Model/Message.php index 1615f8da..fdee5e34 100644 --- a/src/Model/Message.php +++ b/src/Model/Message.php @@ -120,7 +120,7 @@ public function getValue($names, $default = null) /** * {@inheritdoc} */ - public function setCompletedAt(\DateTime $completedAt = null) + public function setCompletedAt(?\DateTime $completedAt = null) { $this->completedAt = $completedAt; } @@ -136,7 +136,7 @@ public function getCompletedAt() /** * {@inheritdoc} */ - public function setCreatedAt(\DateTime $createdAt = null) + public function setCreatedAt(?\DateTime $createdAt = null) { $this->createdAt = $createdAt; } @@ -216,7 +216,7 @@ public function getRestartCount() /** * {@inheritdoc} */ - public function setUpdatedAt(\DateTime $updatedAt = null) + public function setUpdatedAt(?\DateTime $updatedAt = null) { $this->updatedAt = $updatedAt; } @@ -246,7 +246,7 @@ public static function getStateList() /** * {@inheritdoc} */ - public function setStartedAt(\DateTime $startedAt = null) + public function setStartedAt(?\DateTime $startedAt = null) { $this->startedAt = $startedAt; } diff --git a/src/Model/MessageInterface.php b/src/Model/MessageInterface.php index 87b90f07..2a6cec0a 100644 --- a/src/Model/MessageInterface.php +++ b/src/Model/MessageInterface.php @@ -42,7 +42,7 @@ public function getValue($names, $default = null); /** * @param \DateTime $completedAt */ - public function setCompletedAt(\DateTime $completedAt = null); + public function setCompletedAt(?\DateTime $completedAt = null); /** * @return \DateTime @@ -52,7 +52,7 @@ public function getCompletedAt(); /** * @param \DateTime $createdAt */ - public function setCreatedAt(\DateTime $createdAt = null); + public function setCreatedAt(?\DateTime $createdAt = null); /** * @return \DateTime @@ -102,7 +102,7 @@ public function getRestartCount(); /** * @param \DateTime $updatedAt */ - public function setUpdatedAt(\DateTime $updatedAt = null); + public function setUpdatedAt(?\DateTime $updatedAt = null); /** * @return \DateTime @@ -112,7 +112,7 @@ public function getUpdatedAt(); /** * @param \DateTime $startedAt */ - public function setStartedAt(\DateTime $startedAt = null); + public function setStartedAt(?\DateTime $startedAt = null); /** * @return \DateTime diff --git a/tests/Entity/MessageManagerMock.php b/tests/Entity/MessageManagerMock.php index 33e54763..9ce1993b 100644 --- a/tests/Entity/MessageManagerMock.php +++ b/tests/Entity/MessageManagerMock.php @@ -23,7 +23,7 @@ class MessageManagerMock extends MessageManager /** * {@inheritdoc} */ - public function findBy(array $criteria, array $orderBy = null, $limit = null, $offset = null) + public function findBy(array $criteria, ?array $orderBy = null, $limit = null, $offset = null) { $result = []; while (null !== $limit && $limit > 0) {