Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow magic _call for DoctrineORMQuerySourceIterator #41

Closed
wants to merge 1 commit into from

Conversation

@soullivaneuh
Copy link
Member

soullivaneuh commented Jun 10, 2015

@webda2l Could you please rebase your PR?

@rande What you you think about it? Should be accepted? I would like to resolve it for version bumping (#47).

@soullivaneuh
Copy link
Member

soullivaneuh commented Jun 10, 2015

@webda2l And as well, can you explain your modifications on the changelog?

@rande
Copy link
Member

rande commented Jun 10, 2015

The tests are missing. Yes we can merge it once this will be ready

@soullivaneuh
Copy link
Member

soullivaneuh commented Jun 10, 2015

Well, @webda2l there is the todo list to get this PR accepted:

  • Rebased PR
  • Adding line note on changelog
  • Update / make related tests
  • Squashing commits

Please ping me when it's done. 👍

Thanks.

@core23
Copy link
Member

core23 commented Jan 28, 2016

@webda2l Are you still working on this?

@webda2l
Copy link
Author

webda2l commented Jan 29, 2016

@core23 No, busy currently, feel free to continue

@soullivaneuh
Copy link
Member

soullivaneuh commented May 16, 2016

According to the new Sonata version management and next major release plan, this project has been refactored regarding branching and versioning.

If you see this message, your PR concerns a patch or a minor release and is not targeting the right branch.

So I'm closing this one, but don't see it as a refusal. If you think your work is still relevant and want to continue, feel free to reopen it on the right branch (e.g. the default one).

Regards.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
You can’t perform that action at this time.