Allow magic _call for DoctrineORMQuerySourceIterator #41

Closed
wants to merge 1 commit into
from

Conversation

Projects
None yet
4 participants
@Soullivaneuh

This comment has been minimized.

Show comment
Hide comment
@Soullivaneuh

Soullivaneuh Jun 10, 2015

Member

@webda2l Could you please rebase your PR?

@rande What you you think about it? Should be accepted? I would like to resolve it for version bumping (#47).

Member

Soullivaneuh commented Jun 10, 2015

@webda2l Could you please rebase your PR?

@rande What you you think about it? Should be accepted? I would like to resolve it for version bumping (#47).

@Soullivaneuh

This comment has been minimized.

Show comment
Hide comment
@Soullivaneuh

Soullivaneuh Jun 10, 2015

Member

@webda2l And as well, can you explain your modifications on the changelog?

Member

Soullivaneuh commented Jun 10, 2015

@webda2l And as well, can you explain your modifications on the changelog?

@rande

This comment has been minimized.

Show comment
Hide comment
@rande

rande Jun 10, 2015

Member

The tests are missing. Yes we can merge it once this will be ready

Member

rande commented Jun 10, 2015

The tests are missing. Yes we can merge it once this will be ready

@Soullivaneuh

This comment has been minimized.

Show comment
Hide comment
@Soullivaneuh

Soullivaneuh Jun 10, 2015

Member

Well, @webda2l there is the todo list to get this PR accepted:

  • Rebased PR
  • Adding line note on changelog
  • Update / make related tests
  • Squashing commits

Please ping me when it's done. 👍

Thanks.

Member

Soullivaneuh commented Jun 10, 2015

Well, @webda2l there is the todo list to get this PR accepted:

  • Rebased PR
  • Adding line note on changelog
  • Update / make related tests
  • Squashing commits

Please ping me when it's done. 👍

Thanks.

@core23

This comment has been minimized.

Show comment
Hide comment
@core23

core23 Jan 28, 2016

Member

@webda2l Are you still working on this?

Member

core23 commented Jan 28, 2016

@webda2l Are you still working on this?

@webda2l

This comment has been minimized.

Show comment
Hide comment
@webda2l

webda2l Jan 29, 2016

@core23 No, busy currently, feel free to continue

webda2l commented Jan 29, 2016

@core23 No, busy currently, feel free to continue

@Soullivaneuh

This comment has been minimized.

Show comment
Hide comment
@Soullivaneuh

Soullivaneuh May 16, 2016

Member

According to the new Sonata version management and next major release plan, this project has been refactored regarding branching and versioning.

If you see this message, your PR concerns a patch or a minor release and is not targeting the right branch.

So I'm closing this one, but don't see it as a refusal. If you think your work is still relevant and want to continue, feel free to reopen it on the right branch (e.g. the default one).

Regards.

Member

Soullivaneuh commented May 16, 2016

According to the new Sonata version management and next major release plan, this project has been refactored regarding branching and versioning.

If you see this message, your PR concerns a patch or a minor release and is not targeting the right branch.

So I'm closing this one, but don't see it as a refusal. If you think your work is still relevant and want to continue, feel free to reopen it on the right branch (e.g. the default one).

Regards.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment