From ece658ba580cfb6e89dcb903651c74367296592b Mon Sep 17 00:00:00 2001 From: Jordi Sala Morales Date: Sat, 14 May 2022 10:12:48 +0200 Subject: [PATCH] Restore PHP 7.3 compatibility --- .github/workflows/test.yaml | 5 +++++ src/Twig/CanonicalizeRuntime.php | 5 ++++- tests/Twig/CanonicalizeRuntimeTest.php | 10 ++++++++-- 3 files changed, 17 insertions(+), 3 deletions(-) diff --git a/.github/workflows/test.yaml b/.github/workflows/test.yaml index a8c377f2..9ac13f7e 100644 --- a/.github/workflows/test.yaml +++ b/.github/workflows/test.yaml @@ -27,6 +27,7 @@ jobs: strategy: matrix: php-version: + - '7.3' - '7.4' - '8.0' - '8.1' @@ -35,6 +36,10 @@ jobs: symfony-require: [''] variant: [normal] include: + - php-version: '7.3' + dependencies: lowest + allowed-to-fail: false + variant: normal - php-version: '7.4' dependencies: lowest allowed-to-fail: false diff --git a/src/Twig/CanonicalizeRuntime.php b/src/Twig/CanonicalizeRuntime.php index 84bdbb04..1af1dd00 100644 --- a/src/Twig/CanonicalizeRuntime.php +++ b/src/Twig/CanonicalizeRuntime.php @@ -26,7 +26,10 @@ final class CanonicalizeRuntime implements RuntimeExtensionInterface 'fr' => ['fr', 'fr-ca', 'fr-ch'], ]; - private RequestStack $requestStack; + /** + * @var RequestStack + */ + private $requestStack; /** * @internal This class should only be used through Twig diff --git a/tests/Twig/CanonicalizeRuntimeTest.php b/tests/Twig/CanonicalizeRuntimeTest.php index cdf9cdd7..cbd9cf18 100644 --- a/tests/Twig/CanonicalizeRuntimeTest.php +++ b/tests/Twig/CanonicalizeRuntimeTest.php @@ -20,9 +20,15 @@ final class CanonicalizeRuntimeTest extends TestCase { - private Request $request; + /** + * @var Request + */ + private $request; - private CanonicalizeRuntime $canonicalizeRuntime; + /** + * @var CanonicalizeRuntime + */ + private $canonicalizeRuntime; protected function setUp(): void {