You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository has been archived by the owner on Jul 28, 2022. It is now read-only.
This is unreliable and will break, if the bundle exists, but isn't enabled. Of course I can set orm_listener/phpcr_odm_listener manually to false (from auto), but that is usually not something somebody expect from an automation.
The text was updated successfully, but these errors were encountered:
well yes, that is the point of auto but keeping the option to explicitly set false. i don't know if we could improve by checking if the kernel knows about the orm / phpcr bundle. at some places, there is code in the cmf where we get the list of bundle names from the kernel and check those, instead of class_exists. if you have a PR for that, it would make sense imo. otherwise its just that for a weird edge case (having the code in classpath but not enabled the bundle) you need to configure something more.
If I am not completely wrong one can get the registered bundles with $container->getParameter('kernel.bundles'). I've already seen something different somewhere else (afair it was about prependConfiguration() somehow ❓ ). So I think somehow it is possible
I don't know, if it's a werid edge-case 😉 But I often disable bundles first and test it, before I remove them completely.
Another case would be (also: Don't know, how common this is), if someone has multiple applications within one project.
So, as far as I can see it shouldn't be that complicated. Don't know, when I find some time for that 😉
Well... Wanted to provide a PR, but then I realize: It (the snippet I complained about) doesn't depend on a bundle, thus my approach isn't valid. I'm still convinced, that it requires the corresponding bundles, but I'm not sure.
Currently the bundle only test, if the class exists:
This is unreliable and will break, if the bundle exists, but isn't enabled. Of course I can set
orm_listener
/phpcr_odm_listener
manually tofalse
(fromauto
), but that is usually not something somebody expect from an automation.The text was updated successfully, but these errors were encountered: