From c74b7f387ccfbaf35cdc3d703b8450956ddbb711 Mon Sep 17 00:00:00 2001 From: rmealing Date: Tue, 11 Oct 2022 18:32:38 +0100 Subject: [PATCH] Add parent ID to module xml --- gradle.properties | 2 +- .../plugins/scan/common/DependenciesFinder.java | 13 ++++++++++--- .../plugins/scan/common/DependenciesFinderTest.java | 2 ++ 3 files changed, 13 insertions(+), 4 deletions(-) diff --git a/gradle.properties b/gradle.properties index 931dbcc..962ae3f 100644 --- a/gradle.properties +++ b/gradle.properties @@ -18,7 +18,7 @@ group=org.sonatype.gradle.plugins version=2.5.2-SNAPSHOT release.useAutomaticVersion=true -nexusPlatformApiVersion=4.0.0-01 +nexusPlatformApiVersion=4.0.3-SNAPSHOT ossIndexClientVersion=1.8.1 feignVersion=11.8 gsonVersion=2.9.0 diff --git a/src/main/java/org/sonatype/gradle/plugins/scan/common/DependenciesFinder.java b/src/main/java/org/sonatype/gradle/plugins/scan/common/DependenciesFinder.java index c167204..8d37402 100644 --- a/src/main/java/org/sonatype/gradle/plugins/scan/common/DependenciesFinder.java +++ b/src/main/java/org/sonatype/gradle/plugins/scan/common/DependenciesFinder.java @@ -130,6 +130,15 @@ Module buildModule(Project project) { .setBuilderInfo(Module.BI_CLM_TOOL, "gradle") .setBuilderInfo(Module.BI_CLM_VERSION, PluginVersionUtils.getPluginVersion()); + module.setId(getId(project)); + if (project.getParent() != null) { + module.setParentId(getId(project.getParent())); + } + + return module; + } + + String getId(Project project) { StringBuilder idBuilder = new StringBuilder(); if (StringUtils.isNotBlank(project.getGroup().toString())) { idBuilder.append(project.getGroup().toString()).append(":"); @@ -139,9 +148,7 @@ Module buildModule(Project project) { && !"unspecified".equals(project.getVersion().toString())) { idBuilder.append(":").append(project.getVersion().toString()); } - module.setId(idBuilder.toString()); - - return module; + return idBuilder.toString(); } @VisibleForTesting diff --git a/src/test/java/org/sonatype/gradle/plugins/scan/common/DependenciesFinderTest.java b/src/test/java/org/sonatype/gradle/plugins/scan/common/DependenciesFinderTest.java index f9dc601..e894886 100644 --- a/src/test/java/org/sonatype/gradle/plugins/scan/common/DependenciesFinderTest.java +++ b/src/test/java/org/sonatype/gradle/plugins/scan/common/DependenciesFinderTest.java @@ -290,11 +290,13 @@ public void testFindModules_multiModule() { Module parentModule = modules.get(0); assertThat(parentModule.getId()).isEqualTo(parentProject.getName()); assertThat(parentModule.getConsumedArtifacts()).isEmpty(); + assertThat(parentModule.getParentId()).isNull(); Module childModule = modules.get(1); assertThat(childModule.getId()).isEqualTo(parentProject.getName() + ":" + childProject.getName()); assertThat(childModule.getConsumedArtifacts()).hasSize(1); assertThat(childModule.getDependencies()).hasSize(1); + assertThat(childModule.getParentId()).isEqualTo(parentProject.getName()); Dependency dependency = childModule.getDependencies().get(0); assertThat(dependency.getId()).isEqualTo(COMMONS_COLLECTIONS_DEPENDENCY);