REVIEW NEXUS-6692: Fix url validation and error handling #635

Merged
merged 1 commit into from Jul 17, 2014

3 participants

@cstamas
Sonatype member

Changes:

  • the regex was too strict, not allowing port numbers nor localhost with paths
  • on repo creation, the validation error was swallowed (wrapped into another config ex)
  • on repo update the validation was not handled resulting in generic config error
  • aligned regex in legacy and rapture UI

Issue
https://issues.sonatype.org/browse/NEXUS-6692

CI
http://bamboo.s/browse/NX-OSSF164

@cstamas cstamas NEXUS-6692: Fix url validation and error handling
Changes:
* the regex was too strict, not allowing port numbers nor localhost with paths
* on repo creation, the validation error was swallowed (wrapped into another config ex)
* on repo update the validation was not handled resulting in generic config error
* aligned regex in legacy and rapture UI
fc2a270
@jdillon

+1

we should remove ftp support while we are at it, which should address https://issues.sonatype.org/browse/NEXUS-3235

@cstamas cstamas merged commit 80a8f21 into master Jul 17, 2014
@jdillon jdillon deleted the NEXUS-6692-fix-url branch Aug 31, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment