o [NEXUS-5064] Enable connection pooling for ssl ldap connections as well #446
Conversation
+1 |
1 similar comment
+1 |
-1 as is |
Well, as far as I see, according to this http://docs.oracle.com/javase/jndi/tutorial/ldap/connect/config.html The change looks okay. Do we want to test Sun JNDI? ;) |
um no that would be integration test...I mean given xyz conditions, ensure pooling is configured too bad... if we wrote a unit test for this stuff - perhaps we would notice that searchBase is checked for not null, but then never used... |
I actually think Nexus only uses the PlexusLdapContextFActory, which IIRC seems to have been a copy of the DefaultLdapContextFactory |
Is DefaultLdapContextFactory being used anywhere? Hopefully there is a good reason we have both. |
Anyone know why we have both context factories? |
It looks like
This test was aparently not exercised for a long time, it is excluded in the POM and manually running will give nothing but NPEs. EDIT: Not even NPEs, but there's apparently the ApplicationEvent muck missing from classpath, tests do not even set up correctly. |
thx for the test |
o [NEXUS-5064] Enable connection pooling for ssl ldap connections as well
https://builds.sonatype.org/job/nexus-oss-its-feature/362/