Skip to content

NEXUS-5241: Simple fix #531

Merged
merged 2 commits into from Sep 14, 2012

4 participants

@cstamas
Sonatype member
cstamas commented Sep 5, 2012

A simple fix fixing the issue, easily backportable to 2.1 line too.

cstamas added some commits Sep 5, 2012
@cstamas cstamas NEXUS-5241: Simple fix to not have some events stored to Timeline.
Simply adding extra checks: event to be stored relates to a path
that is:

* NOT maven repository metadata file (maven-metadata.xml)
* NOT maven artifact signature file (*.asc)
* NOT maven checksum file (*.sha1 or *.md5)

Note: this change makes Timeline Maven-support dependant. Today, this is
fine as Maven support happens to be in Core, but once moved out, this
solution will either require to have Timeline plugin depend on Maven plugin
(which is wrong) or removal of this change will be needed.
c37eca1
@cstamas cstamas NEXUS-5241: UT covering change 3ce3342
@adreghiciu

+1

@ifedorenko

Will it make more sense to check for specific items to include in the timeline instead of items to exclude?

@nabcos
nabcos commented Sep 6, 2012

If we have a whitelist of things to include, do we need a way for plugins to contribute to that whitelist? The exclusions are for maven-specific things (which is still in nexus-core, by chance), what about p2/obr/nuget/yum/ruby?

EDIT: actually a blacklist might also need plugin contributions

@cstamas
Sonatype member
@nabcos
nabcos commented Sep 6, 2012

OK, I did not get that. Should we merge this only to 2.1.x then, and leave the issue open for 2.2?

@cstamas cstamas merged commit 3350061 into master Sep 14, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.