Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

HttpClient 4x being slow with HTTPS connections. #560

Merged
merged 1 commit into from Oct 5, 2012

Conversation

Projects
None yet
3 participants
Contributor

cstamas commented Oct 4, 2012

Changes in here:

  • bumped version to httpclient 4.2.1 + httpcore 4.2.2 (latest GA)
  • applied recommended changes to connManager, parameters handling
  • catching IllegalStateException thrown by httpClient connmgr in case when JVM lacks support for TLS (was swallowed without this!)
  • removing explicit connection close, to make use of pooling
  • hostname verification for HTTPS connections (new in HC4x, not done by HC3x!) left in place, but due to pooling it is made only once, when connection created and not after it (when connection is reused).

These changes makes the originally 2.5x times slower HC4 (vs HC3) against HTTPS servers about 3.0x times faster!

Related issue: https://issues.sonatype.org/browse/NEXUS-5291

HttpClient 4x being slow with HTTPS connections.
* bumped version to httpclient 4.2.1 + httpcore 4.2.2 + httpmime 4.2.1 (latest GA)
* applied recommended changes to connManager, parameters handling
* catching IllegalStateException thrown by httpClient connmgr in case when JVM lacks support for TLS (was swallowed without this)
* removing explicit connection close, to make use of pooling
Member

peterlynch commented Oct 4, 2012

+1

Contributor

cstamas commented Oct 5, 2012

CI linux passed, win had one unrelated (but search related) IT failure. I count this as +1

Contributor

adreghiciu commented Oct 5, 2012

+1

cstamas added a commit that referenced this pull request Oct 5, 2012

Merge pull request #560 from sonatype/httpclient4x-bump
HttpClient 4x being slow with HTTPS connections.

@cstamas cstamas merged commit 26dae8b into master Oct 5, 2012

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment