Replaced testng with junit4 #712

Merged
merged 9 commits into from Jan 8, 2013

Projects

None yet

6 participants

ifedorenko added some commits Jan 5, 2013
@ifedorenko ifedorenko mostly mechanical changes to replace testng with junit4
Signed-off-by: Igor Fedorenko <igor@ifedorenko.com>
ab05a21
@ifedorenko ifedorenko Removed testng test ordering, may need more work
Signed-off-by: Igor Fedorenko <igor@ifedorenko.com>
c0fec2d
@ifedorenko ifedorenko migrated parameterized testng test to junit4
Signed-off-by: Igor Fedorenko <igor@ifedorenko.com>
c4bef96
@ifedorenko ifedorenko fixed Nexus1806ValidateSmtpConfigurationIT cleanup after tests
EmailUtil keeps private static server instance. Stopping the
instance directly instead of calling EmailUtil.stopEmailServer
breaks future calls to EmailUtil.startEmailServer.

Signed-off-by: Igor Fedorenko <igor@ifedorenko.com>
a55a0f9
@ifedorenko ifedorenko Fixed Cargo WAR tests to create container config under target/
Original implementation created configuration config under
System.getProperty("java.io.tmpdir"), this unnecessary complicated
finding container configuration and logs during test failure
debugging.

Signed-off-by: Igor Fedorenko <igor@ifedorenko.com>
2da3037
Contributor
jdillon commented Jan 6, 2013

YAY!

Contributor

+1

Contributor
cstamas commented Jan 7, 2013

+1

@nabcos nabcos commented on the diff Jan 7, 2013
...ests/client/nexus725/Nexus725InitialRestClientIT.java
@@ -68,7 +68,7 @@ public void getRepoListTest()
NexusClient client = this.getConnectedNexusClient();
List<RepositoryListResource> repos = client.getRepositories();
- Assert.assertTrue( repos.size() > 0, "Expected list of repos to be larger then 0" );
+ Assert.assertTrue( "Expected list of repos to be larger then 0", repos.size() > 0 );
nabcos
nabcos Jan 7, 2013 Contributor

Please use hamcrest instead.
(SCNR :o)

ifedorenko
ifedorenko Jan 7, 2013 Contributor

Yes, these do need to be cleaned up and fixed, but they are unrelated to testng->junit4 migration and should be dealt with separately.

At least this code asserts something meaningful. There are places where tests assert static string is not null (likely due to mixed parameter order when the tests were originally migrated from junit to testng) and places tests that simply make no sense, like assertNotNull(int) I mentioned yesterday.
jdillon
jdillon Jan 7, 2013 Contributor

I agree, it should using hamcrest or fest or something else, but that we shouldn't complicate the killing of testng with rewriting tests wrt to how they assert.

Member

+1

@ifedorenko ifedorenko merged commit 175c222 into master Jan 8, 2013
@peterlynch

Isn't this pulled in from litmus-testsupport now?

@jdillon
Contributor

Yes, this change was before your change to litmus.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment