Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP

Loading…

Replaced testng with junit4 #712

Merged
merged 9 commits into from

6 participants

ifedorenko Jason Dillon Alin Dreghiciu Tamas Cservenak Peter Lynch Benjamin Hanzelmann
ifedorenko added some commits
ifedorenko ifedorenko mostly mechanical changes to replace testng with junit4
Signed-off-by: Igor Fedorenko <igor@ifedorenko.com>
ab05a21
ifedorenko ifedorenko Removed testng test ordering, may need more work
Signed-off-by: Igor Fedorenko <igor@ifedorenko.com>
c0fec2d
ifedorenko ifedorenko migrated parameterized testng test to junit4
Signed-off-by: Igor Fedorenko <igor@ifedorenko.com>
c4bef96
ifedorenko ifedorenko fixed Nexus1806ValidateSmtpConfigurationIT cleanup after tests
EmailUtil keeps private static server instance. Stopping the
instance directly instead of calling EmailUtil.stopEmailServer
breaks future calls to EmailUtil.startEmailServer.

Signed-off-by: Igor Fedorenko <igor@ifedorenko.com>
a55a0f9
ifedorenko ifedorenko Fixed Cargo WAR tests to create container config under target/
Original implementation created configuration config under
System.getProperty("java.io.tmpdir"), this unnecessary complicated
finding container configuration and logs during test failure
debugging.

Signed-off-by: Igor Fedorenko <igor@ifedorenko.com>
2da3037
Jason Dillon
Owner

YAY!

Alin Dreghiciu
Owner

+1

Tamas Cservenak
Owner

+1

Benjamin Hanzelmann nabcos commented on the diff
...ests/client/nexus725/Nexus725InitialRestClientIT.java
@@ -68,7 +68,7 @@ public void getRepoListTest()
NexusClient client = this.getConnectedNexusClient();
List<RepositoryListResource> repos = client.getRepositories();
- Assert.assertTrue( repos.size() > 0, "Expected list of repos to be larger then 0" );
+ Assert.assertTrue( "Expected list of repos to be larger then 0", repos.size() > 0 );
Benjamin Hanzelmann
nabcos added a note

Please use hamcrest instead.
(SCNR :o)

Yes, these do need to be cleaned up and fixed, but they are unrelated to testng->junit4 migration and should be dealt with separately.


At least this code asserts something meaningful. There are places where tests assert static string is not null (likely due to mixed parameter order when the tests were originally migrated from junit to testng) and places tests that simply make no sense, like assertNotNull(int) I mentioned yesterday.

Jason Dillon Owner
jdillon added a note

I agree, it should using hamcrest or fest or something else, but that we shouldn't complicate the killing of testng with rewriting tests wrt to how they assert.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Peter Lynch
Owner

+1

ifedorenko ifedorenko merged commit 175c222 into from
Peter Lynch

Isn't this pulled in from litmus-testsupport now?

Jason Dillon
Owner

Yes, this change was before your change to litmus.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Commits on Jan 6, 2013
  1. ifedorenko

    mostly mechanical changes to replace testng with junit4

    ifedorenko authored
    Signed-off-by: Igor Fedorenko <igor@ifedorenko.com>
  2. ifedorenko

    Removed testng test ordering, may need more work

    ifedorenko authored
    Signed-off-by: Igor Fedorenko <igor@ifedorenko.com>
  3. ifedorenko

    migrated parameterized testng test to junit4

    ifedorenko authored
    Signed-off-by: Igor Fedorenko <igor@ifedorenko.com>
  4. ifedorenko

    fixed Nexus1806ValidateSmtpConfigurationIT cleanup after tests

    ifedorenko authored
    EmailUtil keeps private static server instance. Stopping the
    instance directly instead of calling EmailUtil.stopEmailServer
    breaks future calls to EmailUtil.startEmailServer.
    
    Signed-off-by: Igor Fedorenko <igor@ifedorenko.com>
  5. ifedorenko

    Fixed Cargo WAR tests to create container config under target/

    ifedorenko authored
    Original implementation created configuration config under
    System.getProperty("java.io.tmpdir"), this unnecessary complicated
    finding container configuration and logs during test failure
    debugging.
    
    Signed-off-by: Igor Fedorenko <igor@ifedorenko.com>
Commits on Jan 7, 2013
  1. Jason Dillon
  2. Jason Dillon
  3. Jason Dillon

    Update to maven-verifier 1.4. Strip out the entire log content which …

    jdillon authored
    …is include in the exception message by default, instead point to log file.
  4. Jason Dillon
Something went wrong with that request. Please try again.