REVIEW: NEXUS-5615 update UI to indicate first/last name are required and add a last name t... #798

Merged
merged 2 commits into from Apr 5, 2013

Projects

None yet

3 participants

@kellyrob99
Owner

...o default admin user for new deployments

https://issues.sonatype.org/browse/NEXUS-5615

@kellyrob99 kellyrob99 update UI to indicate first/last name are required and add a last nam…
…e to default admin user for new deployments

NEXUS-5615
ebd6066
Contributor
jdillon commented Apr 4, 2013

Please cross link github and jira... so its easier to move between them.

https://issues.sonatype.org/browse/NEXUS-5615

@jdillon jdillon commented on an outdated diff Apr 4, 2013
...ore/src/main/resources/META-INF/security/security.xml
@@ -21,6 +21,7 @@
<user>
<id>admin</id>
<firstName>Administrator</firstName>
+ <lastName>Nexus</lastName>
jdillon
jdillon Apr 4, 2013 Contributor

probably should be:

<lastName>User</lastName>

... which matches the others closer.

indent is also off but so is this entire file :-\

Contributor
jdillon commented Apr 4, 2013

This doesn't actually fix existing installations... but not sure we care too much about those, since hopefully they have deleted this user ;-)

Owner

I considered updating existing installations, but since there's no functionality that is broken as-s it seemed overkill for such a small issue.
If anyone feels strongly about that, I'd welcome the opportunity to start learning about how to upgrade the configuration xml files properly.

Contributor
jdillon commented Apr 4, 2013

@kellyrob99 its not worth the trouble don't bother.

Contributor

+1

Contributor
jdillon commented Apr 5, 2013

+1

@kellyrob99 kellyrob99 merged commit 03f7bd8 into master Apr 5, 2013
@kellyrob99 kellyrob99 deleted the NEXUS_5615 branch Apr 5, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment