Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

BourneShell.getExecutionPreamble does not escape the dollar sign in a directory name #10

Closed
wants to merge 1 commit into
from

Conversation

Projects
None yet
3 participants

orivej commented Mar 3, 2013

BourneShell.getExecutionPreamble calls unifyQuotes( dir ), which calls StringUtils.quoteAndEscape( path, '\"', BASH_QUOTING_TRIGGER_CHARS );, which calls six-arg .quoteAndEscape in such a way that, for example, abc$xyz becomes "abc$xyz" and .getExecutionPreamble produces cd "abc$xyz" && ... which does not work because of shell interpolation of $xyz inside double quotes.

Collaborator

krosenvold commented Mar 3, 2013

Test-cases and/org patches are welcome

orivej commented Mar 3, 2013

Here is a copypasted testcase which checks that dollar sign is escaped inside double quotes.

@kellyrob99 kellyrob99 closed this Aug 10, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment