Bugfixes for down migrations, and a rollback method #59

Merged
merged 3 commits into from Aug 21, 2013

Conversation

Projects
None yet
2 participants
@gregates
Contributor

gregates commented Aug 19, 2013

Tried installing this gem on a project I'm working on today. After running the database migrations, as per my usual practice, I tried rolling them back. This failed due two a couple of small bugs in the down methods for the migrations.

This pull request fixes those bugs. It also adds a ::rollback class method (aliased as ::down) to the Songkick::OAuth2::Schema class, to mirror the ::migrate class method.

gregates added some commits Aug 19, 2013

jcoglan added a commit that referenced this pull request Aug 21, 2013

Merge pull request #59 from gregates/down_migrations_revised
Bugfixes for down migrations, and a rollback method

@jcoglan jcoglan merged commit cd5a71a into songkick:master Aug 21, 2013

1 check passed

default The Travis CI build passed
Details
@jcoglan

This comment has been minimized.

Show comment Hide comment
@jcoglan

jcoglan Aug 21, 2013

Contributor

@gregates Thank you!

Contributor

jcoglan commented Aug 21, 2013

@gregates Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment