New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add V1 traps, fix examples, fix TrapListener logging #107

Merged
merged 3 commits into from Jun 19, 2017

Conversation

Projects
None yet
2 participants
@blind-oracle

blind-oracle commented Jun 15, 2017

  1. Trap example panics because TrapListener.c *sync.Cond is nil, switch to NewTrapListener()
  2. TrapListener does not log anything because validateParameters() isn't called in Listen(). Fix this.
  3. Add support for receiving V1 traps

@blind-oracle blind-oracle changed the title from Fix examples, fix TrapListener logging to Add V1 traps, fix examples, fix TrapListener logging Jun 15, 2017

@wdreeveii wdreeveii merged commit 945562d into soniah:master Jun 19, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@wdreeveii

This comment has been minimized.

Collaborator

wdreeveii commented Jun 19, 2017

Thanks - Looks good to me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment