Thread safety in logger #26

merged 1 commit into from Jun 14, 2012


None yet
2 participants

drewr commented Jun 5, 2012

We ran into an issue where a parameter from the request wasn't available in the response thread of the channel. Store those in final instance params instead of trying to grab them during log construction.

@drewr drewr [ENG-2658] Set params from the request at channel creation.
The request may not be available to the response thread later.

@imotov imotov commented on the diff Jun 5, 2012
@@ -128,6 +143,15 @@ public LoggingHttpChannel(HttpRequest request, HttpChannel channel, String forma
} else {
content = null;

imotov Jun 5, 2012


This portion is not really needed and shouldn't be executed in case of non-json logging. Maybe we should split it into two different Loggers after all.


imotov commented Jun 14, 2012

+1 - let's get this in and then we will refactor it

drewr merged commit 02d48e7 into master Jun 14, 2012

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment