From a3225e65e4756d5893757c8f23693f11d41f4d88 Mon Sep 17 00:00:00 2001 From: xumia <59720581+xumia@users.noreply.github.com> Date: Wed, 15 Feb 2023 22:19:01 +0800 Subject: [PATCH] [Build] Remove the additional space character in the mirrors.list file (#13812) Why I did it Fix all mirror is commented out in sources.list in slave image issue. It will have an issue when installing more packages in the slave container. It will add additional space character after running add-apt-repository command. For example: The original config in /etc/apt/sources.list #deb [arch=amd64] http://deb.debian.org/debian/ bullseye main contrib non-free Run the following command: add-apt-repository "deb [arch=amd64] https://download.docker.com/linux/debian bullseye stable" Then the setting changed to: (added a new space character after #) # deb [arch=amd64] http://deb.debian.org/debian/ bullseye main contrib non-free How I did it Fix the regex string to add the space pattern. After fixed, whether there is a space character or not, it will not be an issue. How to verify it --- src/sonic-build-hooks/scripts/buildinfo_base.sh | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/sonic-build-hooks/scripts/buildinfo_base.sh b/src/sonic-build-hooks/scripts/buildinfo_base.sh index 1e334a4a62da..e10a32303423 100755 --- a/src/sonic-build-hooks/scripts/buildinfo_base.sh +++ b/src/sonic-build-hooks/scripts/buildinfo_base.sh @@ -112,7 +112,7 @@ get_version_cache_option() set_reproducible_mirrors() { # Remove the charater # in front of the line if matched - local expression="s/^#\(.*$REPR_MIRROR_URL_PATTERN\)/\1/" + local expression="s/^#\s*\(.*$REPR_MIRROR_URL_PATTERN\)/\1/" # Add the character # in front of the line, if not match the URL pattern condition local expression2="/^#*deb.*$REPR_MIRROR_URL_PATTERN/! s/^#*deb/#&/" local expression3="\$a#SET_REPR_MIRRORS" @@ -120,7 +120,7 @@ set_reproducible_mirrors() # Add the charater # in front of the line if match expression="s/^deb.*$REPR_MIRROR_URL_PATTERN/#\0/" # Remove the character # in front of the line, if not match the URL pattern condition - expression2="/^#*deb.*$REPR_MIRROR_URL_PATTERN/! s/^#(#*deb)/\1/" + expression2="/^#*deb.*$REPR_MIRROR_URL_PATTERN/! s/^#\s*(#*deb)/\1/" expression3="/#SET_REPR_MIRRORS/d" fi