Add Sonic 3 split disassembly #18
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Today is the 25th anniversary of the European release of Sonic 3. What better day to wrap up work on a complete disassembly of the US Sonic 3 ROM, which in turn is a byte edit of the Japanese version?
I've squashed this PR into four commits that enjoy little interaction between one another. The first one is mostly unrelated to the others: it removes redundant code from the S3Complete build by using otherwise unused functions present in the S&K ROM.
The next commit massages the S&K disassembly to match the Sonic 3 disassembly included in the third commit. The fourth and final commit will hopefully allow Travis CI to verify the built Sonic 3 ROM alongside the two existing build configurations.
Now that I think about it, I have no idea which rules it's going to check this PR against. My intuition tells me it should be based on what sonicretro/master says, but hey I guess we'll find out haha