Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

subversion integration #25

Merged
merged 3 commits into from Mar 29, 2013

Conversation

@eserozvataf
Copy link
Contributor

eserozvataf commented Mar 29, 2013

  • added multiple vcs support.
  • now works with subversion.
  • fixed some strict coding warnings.
larukedi added 3 commits Mar 28, 2013
* now works with subversion.
* fixed some strict coding warnings.
* added muhafiz.conf to repository
larukedi
* Determines the vcs uses stdout or not
* @return bool true if vcs uses stdout
*/
public function usesStdout()

This comment has been minimized.

Copy link
@yuxel

yuxel Mar 29, 2013

Member

bu vcs'nin özelliği olmamalı? php-cs gibi bir "runner" için tüm vcs'lere böyle bir özellik eklemek mantıklı değil
phpcsrunner'a "if vcs==svn -> error" bile daha güzel olur gibi?

@@ -32,11 +31,24 @@ class Phpcsfixer extends RunnersAbstract
public function run(array $files)
{
if ($this->_vcs->usesStdout()) {

This comment has been minimized.

Copy link
@yuxel

yuxel Mar 29, 2013

Member

sadece phpcs-runner için cvs'e bu methodu kabul edemem :)

@yuxel

This comment has been minimized.

Copy link
Member

yuxel commented Mar 29, 2013

merge ediyorum, eline sağlık
şu phpcsrunner sorununa daha sonra bakalım

yuxel added a commit that referenced this pull request Mar 29, 2013
subversion integration
@yuxel yuxel merged commit e98ccc1 into sonsuzdongu:master Mar 29, 2013
1 check passed
1 check passed
default The Travis build passed
Details
@eserozvataf

This comment has been minimized.

Copy link
Contributor Author

eserozvataf commented Mar 29, 2013

teşekkürler. evet eğreti bir çözüm oldu, özellikle method yerine interface yapmak da mümkündü ama yaklaşım aynı sonuçta. yine bunu vcs yerine runner'a yüklemek daha doğru olacak.

@volkan

This comment has been minimized.

Copy link
Contributor

volkan commented on src/Runners/Phpcsfixer.php in 54cdcb6 May 9, 2013

Bu satırı ekleyerek php-cs-fixer'i çalışmaz hale getirmişsiniz. Projede testlerin yazılması elzem bir durum olmuş. Bilginize.

This comment has been minimized.

Copy link
Contributor

eserozvataf replied May 16, 2013

Bununla ilgili bir issue acilmis durumda, yapisal bir degisiklik gerekiyor gibi Git'de oldugu gibi local erisemiyorsunuz Subversion'da eger dosya henuz commit edilmediyse. Bir oneriniz varsa uygulayabiliriz.

#27

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.