Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix: forward(clear_no_need_grad=True) and nn.grad of Dropout #313

Merged

Conversation

KazukiYoshiyama-sony
Copy link
Contributor

  1. forward(clear_no_need_grad=True)
  • PythonFunction was ignored in conjunction with clear_no_need_grad=True, resulting in the unnecessary memory buffer clear
  • PythonFunction is now taken care of with clear_no_need_grad=True
  • Besides, tests of clear_no_need_grad=True for all functions and backward functions are added now to ensure the results between clear_no_need_grad=True and False.
  1. Dropout mask
  • In the backward function of the dropout, the original 0 values were also masked regardless of the dropout mask.
  • Now, the dropout returns a mask as option used in nn.grad.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note-bugfix Auto-release; Bug fixes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants