QcRilAmService: Wait for IQcRilAudio to be up#8
Merged
jerpelea merged 1 commit intosonyxperiadev:masterfrom May 27, 2020
ix5:getservice-retry
Merged
QcRilAmService: Wait for IQcRilAudio to be up#8jerpelea merged 1 commit intosonyxperiadev:masterfrom ix5:getservice-retry
jerpelea merged 1 commit intosonyxperiadev:masterfrom
ix5:getservice-retry
Conversation
The default call to getService of a HIDL/AIDL interface will not wait for the service to be up. Use the retry parameter to use tryGetService internally. This will fix a deprecation warning on future Android versions. See https://android-review.googlesource.com/c/platform/system/tools/hidl/+/1291900
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The default call to getService of a HIDL/AIDL interface will not wait for the service to be up. Use the
retryparameter to usetryGetServiceinternally.This will fix a deprecation warning on future Android versions.
See https://android-review.googlesource.com/c/platform/system/tools/hidl/+/1291900