-
Notifications
You must be signed in to change notification settings - Fork 139
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
init: Boot DSP before SLPI again #598
Conversation
7f0d242
to
d7286e3
Compare
Updated PR with the following changes:
|
Tested successfully on kagura, but needs testing on other platforms. |
|
With further results rolling in it appears that this PR isn't needed after all. |
Updated to remove the 2s sleep delay. Tested for weeks on kagura with no regressions. |
Tested exhaustively, also on tama. Fixes urgent adsp race on tone. |
2905226
to
572f1c5
Compare
Before 8792c97, adsp and cdsp were booted before slpi: init.qcom.devstart.sh echo 1 > /sys/kernel/boot_adsp/boot echo 1 > /sys/kernel/boot_cdsp/boot echo 1 > /sys/kernel/boot_slpi/boot 8792c97 changed that behaviour to first booting SLPI via init.qcom.devstart.sh, setting vendor.qcom.devup=1 and only then booting ADSP/CSDP via init.qcom.(adsp|cdsp)start.sh. That and later commits caused race conditions that meant audio was gone on tone devices every other boot. This commit restores the old behaviour of first booting ADSP/CDSP and then SLPI.
init: Boot DSP before SLPI again
Before 8792c97, adsp and cdsp were booted before slpi:
8792c97 changed that behaviour to first booting SLPI via
init.qcom.devstart.sh
, settingvendor.qcom.devup=1
and only then booting ADSP/CSDP viainit.qcom.(adsp|cdsp)start.sh
.That and later commits caused race conditions that meant audio was gone on tone devices every other boot.
This commit restores the old behaviour of first booting ADSP/CDSP and then SLPI.