Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

init: Enable adsprpcd instead of starting #612

Merged
merged 1 commit into from May 23, 2019

Conversation

ix5
Copy link
Contributor

@ix5 ix5 commented May 22, 2019

This fixes the issue of the first boot on forceencrypt taking down adsprpcd without starting it back up again.

init    : processing action (vold.decrypt=trigger_shutdown_framework) from (/init.rc:715)
init    : Service 'vendor.adsprpcd' (pid 592) received signal 9

See: https://android.googlesource.com/platform/system/core/+/refs/tags/android-9.0.0_r39/rootdir/init.rc#716

class main brings it in sync with cdsprpcd, which is also in that class.

We can put it into main because the adsp and slpi devices will have been and remain booted already when the vold.decrypt=trigger_shutdown_framework prop triggers, no need to wait until late_start to start the adsprpcd service back up again.

btw... TOLD YA! :)

This fixes the issue of the first boot on forceencrypt taking down
adsprpcd without starting it back up again.

init    : processing action (vold.decrypt=trigger_shutdown_framework) from (/init.rc:715)
init    : Service 'vendor.adsprpcd' (pid 592) received signal 9

See:
https://android.googlesource.com/platform/system/core/+/refs/tags/android-9.0.0_r39/rootdir/init.rc#716

"class main" brings it in sync with cdsprpcd, which is also in that
class.

We can put it into "main" because the adsp and slpi devices will have
been and remain booted already when the
vold.decrypt=trigger_shutdown_framework prop triggers, no need to wait
until "late_start" to start the adsprpcd service back up again.

btw... TOLD YA! :)
@kholk
Copy link
Contributor

@kholk kholk commented May 22, 2019

🤦‍♂️

@jerpelea jerpelea merged commit 7f6fd62 into sonyxperiadev:master May 23, 2019
@ix5 ix5 deleted the dsp-start-enable branch May 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants