[WIP] common: Simplify treble buildvars, add VNDK pkg#675
Merged
jerpelea merged 1 commit intosonyxperiadev:masterfrom Feb 5, 2020
Merged
[WIP] common: Simplify treble buildvars, add VNDK pkg#675jerpelea merged 1 commit intosonyxperiadev:masterfrom
jerpelea merged 1 commit intosonyxperiadev:masterfrom
Conversation
Since all devices are now fully treble compatible, we can enable PRODUCT_FULL_TREBLE_OVERRIDE. PRODUCT_FULL_TREBLE_OVERRIDE sets: - PRODUCT_TREBLE_LINKER_NAMESPACES - PRODUCT_SEPOLICY_SPLIT - PRODUCT_ENFORCE_VINTF_MANIFEST - PRODUCT_NOTICE_SPLIT And also BOARD_PROPERTY_OVERRIDES_SPLIT_ENABLED indirectly. Setting PRODUCT_USE_VNDK_OVERRIDE is still needed because PRODUCT_USE_VNDK will only be set based on PRODUCT_FULL_TREBLE if the shipping API level is 27 or greater. Also add vndk_package in common so that devices don't need to add it individually. We might get rid of these vars entirely by inheriting products from build/make/product/ at a later date.
ix5
force-pushed
the
treble-buildvars-simplify
branch
from
216d855 to
ea42feb
Compare
Collaborator
|
updates? |
Contributor
Author
|
I've been running with locally for months now. It doesn't change any functionality, just brings all devices in line with the same VNDK packages. |
Collaborator
|
then why is it still under review :) |
Contributor
Author
|
No one bothered to test... ;) |
Collaborator
|
now they will :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since all devices are now fully treble compatible, we can enable
PRODUCT_FULL_TREBLE_OVERRIDE.PRODUCT_FULL_TREBLE_OVERRIDEsets:PRODUCT_TREBLE_LINKER_NAMESPACESPRODUCT_SEPOLICY_SPLITPRODUCT_ENFORCE_VINTF_MANIFESTPRODUCT_NOTICE_SPLITAnd also
BOARD_PROPERTY_OVERRIDES_SPLIT_ENABLEDindirectly.Setting
PRODUCT_USE_VNDK_OVERRIDEis still needed becausePRODUCT_USE_VNDKwill only be set based onPRODUCT_FULL_TREBLEif the shipping API level is 27 or greater.Also add
vndk_packagein common so that devices don't need to add it individually.We might get rid of these vars entirely by inheriting products from
build/make/product/at a later date.