Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] common: Simplify treble buildvars, add VNDK pkg #675

Merged
merged 1 commit into from Feb 5, 2020

Conversation

ix5
Copy link
Contributor

@ix5 ix5 commented Dec 20, 2019

Since all devices are now fully treble compatible, we can enable PRODUCT_FULL_TREBLE_OVERRIDE.

PRODUCT_FULL_TREBLE_OVERRIDE sets:

  • PRODUCT_TREBLE_LINKER_NAMESPACES
  • PRODUCT_SEPOLICY_SPLIT
  • PRODUCT_ENFORCE_VINTF_MANIFEST
  • PRODUCT_NOTICE_SPLIT
    And also BOARD_PROPERTY_OVERRIDES_SPLIT_ENABLED indirectly.

Setting PRODUCT_USE_VNDK_OVERRIDE is still needed because PRODUCT_USE_VNDK will only be set based on PRODUCT_FULL_TREBLE if the shipping API level is 27 or greater.

Also add vndk_package in common so that devices don't need to add it individually.

We might get rid of these vars entirely by inheriting products from build/make/product/ at a later date.

Since all devices are now fully treble compatible, we can enable
PRODUCT_FULL_TREBLE_OVERRIDE.

PRODUCT_FULL_TREBLE_OVERRIDE sets:
- PRODUCT_TREBLE_LINKER_NAMESPACES
- PRODUCT_SEPOLICY_SPLIT
- PRODUCT_ENFORCE_VINTF_MANIFEST
- PRODUCT_NOTICE_SPLIT
And also BOARD_PROPERTY_OVERRIDES_SPLIT_ENABLED indirectly.

Setting PRODUCT_USE_VNDK_OVERRIDE is still needed because
PRODUCT_USE_VNDK will only be set based on PRODUCT_FULL_TREBLE if the
shipping API level is 27 or greater.

Also add vndk_package in common so that devices don't need to add it
individually.

We might get rid of these vars entirely by inheriting products from
build/make/product/ at a later date.
@ix5 ix5 force-pushed the treble-buildvars-simplify branch from 216d855 to ea42feb Compare Dec 20, 2019
@jerpelea
Copy link
Collaborator

@jerpelea jerpelea commented Feb 5, 2020

updates?

@ix5
Copy link
Contributor Author

@ix5 ix5 commented Feb 5, 2020

I've been running with locally for months now. It doesn't change any functionality, just brings all devices in line with the same VNDK packages.

@jerpelea
Copy link
Collaborator

@jerpelea jerpelea commented Feb 5, 2020

then why is it still under review :)

@ix5 ix5 marked this pull request as ready for review Feb 5, 2020
@ix5
Copy link
Contributor Author

@ix5 ix5 commented Feb 5, 2020

No one bothered to test... ;)

@jerpelea
Copy link
Collaborator

@jerpelea jerpelea commented Feb 5, 2020

now they will :)

@jerpelea jerpelea merged commit bdc2b2f into sonyxperiadev:master Feb 5, 2020
@ix5 ix5 deleted the treble-buildvars-simplify branch Feb 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants