common-prop: Sync SurfaceFlinger props#709
Merged
jerpelea merged 1 commit intosonyxperiadev:masterfrom Apr 23, 2020
Merged
Conversation
This was referenced Apr 22, 2020
Until Pie, the ConfigStore HAL was supposed to configure SurfaceFlinger. Google, in their infinite wisdom, got bored of this approach and decided that sysprops (which ConfigStore was supposed to supplant, because of their _obvious drawbacks) were once again all the rage. The ConfigStore HAL is being deprecated and will apparently be removed in R. Translate the uppercase makevars that surfaceflinger.mk used to supply as cflags to configstore internals to sysprops. force_hwc_copy_for_virtual_displays = TARGET_FORCE_HWC_FOR_VIRTUAL_DISPLAYS max_frame_buffer_acquired_buffers = NUM_FRAMEBUFFER_SURFACE_BUFFERS Note: The uppercase vars must be kept because hardware/qcom/display still relies on them at build time. Further adjustments follow in the platform repos. `max_frame_buffer_acquired_buffers` will be overriden there for most devices. For reference: https://android.googlesource.com/platform/frameworks/native/+/refs/tags/android-10.0.0_r33/services/surfaceflinger/sysprop/SurfaceFlingerProperties.sysprop https://android.googlesource.com/platform/hardware/interfaces/+/refs/tags/android-10.0.0_r33/configstore/1.1/default/surfaceflinger.mk
This was referenced Apr 22, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Until Pie, the
ConfigStoreHAL was supposed to configureSurfaceFlinger.Google, in their infinite wisdom, got bored of this approach and decided that sysprops (which
ConfigStore was supposed to supplant, because of their _obvious drawbacks) were once again all the rage.
The ConfigStore HAL is being deprecated and will apparently be removed in R, see the deprecation notice.
Translate the uppercase makevars that
surfaceflinger.mkused to supply as cflags to configstore internals to sysprops.Note: The uppercase vars must be kept because
hardware/qcom/displaystill relies on them at build time.Further adjustments follow in the platform repos.
max_frame_buffer_acquired_bufferswill be overriden there for most devices.For reference:
SurfaceFlingerProperties.sysprop