Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

common-prop: Sync SurfaceFlinger props #709

Merged
merged 1 commit into from Apr 23, 2020
Merged

Conversation

ix5
Copy link
Contributor

@ix5 ix5 commented Apr 22, 2020

Until Pie, the ConfigStore HAL was supposed to configure SurfaceFlinger.
Google, in their infinite wisdom, got bored of this approach and decided that sysprops (which
ConfigStore was supposed to supplant, because of their _obvious drawbacks) were once again all the rage.

The ConfigStore HAL is being deprecated and will apparently be removed in R, see the deprecation notice.

Translate the uppercase makevars that surfaceflinger.mk used to supply as cflags to configstore internals to sysprops.

force_hwc_copy_for_virtual_displays = TARGET_FORCE_HWC_FOR_VIRTUAL_DISPLAYS
max_frame_buffer_acquired_buffers = NUM_FRAMEBUFFER_SURFACE_BUFFERS

Note: The uppercase vars must be kept because hardware/qcom/display still relies on them at build time.

Further adjustments follow in the platform repos.
max_frame_buffer_acquired_buffers will be overriden there for most devices.

For reference:
SurfaceFlingerProperties.sysprop

Until Pie, the ConfigStore HAL was supposed to configure
SurfaceFlinger. Google, in their infinite wisdom, got bored
of this approach and decided that sysprops (which
ConfigStore was supposed to supplant, because of their
_obvious drawbacks) were once again all the rage.

The ConfigStore HAL is being deprecated and will apparently
be removed in R.

Translate the uppercase makevars that surfaceflinger.mk used
to supply as cflags to configstore internals to sysprops.

force_hwc_copy_for_virtual_displays = TARGET_FORCE_HWC_FOR_VIRTUAL_DISPLAYS
max_frame_buffer_acquired_buffers = NUM_FRAMEBUFFER_SURFACE_BUFFERS

Note: The uppercase vars must be kept because
hardware/qcom/display still relies on them at build time.

Further adjustments follow in the platform repos.
`max_frame_buffer_acquired_buffers` will be overriden there
for most devices.

For reference:
https://android.googlesource.com/platform/frameworks/native/+/refs/tags/android-10.0.0_r33/services/surfaceflinger/sysprop/SurfaceFlingerProperties.sysprop
https://android.googlesource.com/platform/hardware/interfaces/+/refs/tags/android-10.0.0_r33/configstore/1.1/default/surfaceflinger.mk
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants