Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[R] packages: Add protobuf vendorcompat lib #717

Merged
merged 1 commit into from Jun 29, 2020

Conversation

ix5
Copy link
Contributor

@ix5 ix5 commented Apr 29, 2020

Our blobs are compiled against libprotobuf-full-cpp.so, but starting in R, Android is using a versioned naming approach, e.g. libprotobuf-cpp-full-3.9.1.so.

See https://r.android.com/1109518

The entry in public.libraries.txt is needed to allow the linker to find and use the lib outside the VNDK.

See https://source.android.com/devices/tech/config/namespaces_libraries

Our blobs are compiled against libprotobuf-full-cpp.so, but
starting in R, Android is using a versioned naming approach,
e.g. libprotobuf-cpp-full-3.9.1.so.

See https://r.android.com/1109518

The entry in public.libraries.txt is needed to allow the
linker to find and use the lib outside the VNDK.

See https://source.android.com/devices/tech/config/namespaces_libraries
@ix5 ix5 changed the title [DONOTMERGE] [R] packages: Add protobuf vendorcompat lib [R] packages: Add protobuf vendorcompat lib Jun 27, 2020
@ix5 ix5 marked this pull request as ready for review Jun 27, 2020
@ix5
Copy link
Contributor Author

ix5 commented Jun 27, 2020

This is ready to merge into R/master.

@jerpelea jerpelea merged commit 6b8c5e1 into sonyxperiadev:master Jun 29, 2020
@ix5 ix5 deleted the protobuf-compat branch Jul 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants