Skip to content

[q-mr1] odm: Add build.prop cleaner - #805

Merged
jerpelea merged 1 commit into
sonyxperiadev:q-mr1from
ix5:odm-cleaner
Jan 22, 2021
Merged

jerpelea merged 1 commit into
sonyxperiadev:q-mr1from
ix5:odm-cleaner

Conversation

@ix5

@ix5 ix5 commented Dec 23, 2020

Copy link
Copy Markdown
Contributor

Certain props need to be filtered out from the proprietary odm image ("Software Binaries") because they are device-specific, while the odm image is released per platform.

Certain props need to be filtered out from the proprietary
odm image ("Software Binaries") because they are
device-specific, while the odm image is released per
platform.
@MarijnS95

MarijnS95 commented Dec 23, 2020 •

Copy link
Copy Markdown
Contributor

Shouldn't this somehow depend on the file being created first? Otherwise this build rule might run before it is created?

Also, any idea why it ends up in /odm/etc/build.prop instead of /odm/build.prop?

@ix5

ix5 commented Dec 23, 2020 •

Copy link
Copy Markdown
Contributor Author

Can't shouldn't this somehow depend on the file being created first? Otherwise this build rule might run before it is created?

You could use LOCAL_REQUIRED_MODULES, but afaics that does not guarantee execution ordering, rather only adds the required module to PRODUCT_PACKAGES.

If you've got a good idea, shoot. (@luk1337 time for the Polish Winged Hussar Cavalry?)

Also, any idea why it ends up in /odm/etc/build.prop instead of /odm/build.prop?

El Goog CADT.

@ix5 ix5 changed the title odm: Add build.prop cleaner [q-mr1] odm: Add build.prop cleaner Dec 23, 2020
@jerpelea

Copy link
Copy Markdown
Collaborator

you can just create a file /odm/build.prop

@ix5

ix5 commented Dec 28, 2020

Copy link
Copy Markdown
Contributor Author

you can just create a file /odm/build.prop

/odm/build.prop will not be recognized by the property service on Q anymore https://android.googlesource.com/platform/system/core/+/refs/tags/android-10.0.0_r41/init/property_service.cpp#892

Of course we could just manually read the file, but I think for now this is a good solution.

@jerpelea
jerpelea merged commit f996390 into sonyxperiadev:q-mr1 Jan 22, 2021
@ix5
ix5 deleted the odm-cleaner branch January 22, 2021 10:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants