Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[q-mr1] odm: Add build.prop cleaner #805

Merged
merged 1 commit into from Jan 22, 2021
Merged

Conversation

ix5
Copy link
Contributor

@ix5 ix5 commented Dec 23, 2020

Certain props need to be filtered out from the proprietary odm image ("Software Binaries") because they are device-specific, while the odm image is released per platform.

Certain props need to be filtered out from the proprietary
odm image ("Software Binaries") because they are
device-specific, while the odm image is released per
platform.
@MarijnS95
Copy link
Contributor

MarijnS95 commented Dec 23, 2020

Shouldn't this somehow depend on the file being created first? Otherwise this build rule might run before it is created?

Also, any idea why it ends up in /odm/etc/build.prop instead of /odm/build.prop?

@ix5
Copy link
Contributor Author

ix5 commented Dec 23, 2020

Can't shouldn't this somehow depend on the file being created first? Otherwise this build rule might run before it is created?

You could use LOCAL_REQUIRED_MODULES, but afaics that does not guarantee execution ordering, rather only adds the required module to PRODUCT_PACKAGES.

If you've got a good idea, shoot. (@luk1337 time for the Polish Winged Hussar Cavalry?)

Also, any idea why it ends up in /odm/etc/build.prop instead of /odm/build.prop?

El Goog CADT.

@ix5 ix5 changed the title odm: Add build.prop cleaner [q-mr1] odm: Add build.prop cleaner Dec 23, 2020
@jerpelea
Copy link
Collaborator

you can just create a file /odm/build.prop

@ix5
Copy link
Contributor Author

ix5 commented Dec 28, 2020

you can just create a file /odm/build.prop

/odm/build.prop will not be recognized by the property service on Q anymore https://android.googlesource.com/platform/system/core/+/refs/tags/android-10.0.0_r41/init/property_service.cpp#892

Of course we could just manually read the file, but I think for now this is a good solution.

@jerpelea jerpelea merged commit f996390 into sonyxperiadev:q-mr1 Jan 22, 2021
@ix5 ix5 deleted the odm-cleaner branch January 22, 2021 10:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants