-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[R] [8.1] No more COPY_HEADERS, default c++ std, CleanSpec, cleanups #29
[R] [8.1] No more COPY_HEADERS, default c++ std, CleanSpec, cleanups #29
Conversation
Change-Id: I4047a18879d41d6f18a6f6b266fdc773e09ea0a6
LOCAL_COPY_HEADERS is deprecated and will throw a build error in Android R. The header includes are duplicated anyway, the `display_headers` module already exports all necessary headers.
Android.bp: `subdirs` is deprecated and unnceeded in Q. Top-level Android.mk: Organize for better readability, account for platforms named `sdm` in addition to `msm`. Treewide: Remove empty `common_includes`.
Fix the removed path so that both obj/ and obj_arm/ are cleared. This ensures that we do not make mistakes when porting away from LOCAL_COPY_HEADERS and get bitten when we finally get around to doing a clean build.
0d48278 |
@oshmoun For completeness let me write the explanation here too :)
The correct way is to only ever return pointers to static readonly strings (eg. a character literal like |
Also, this seems to build totally fine on Q too (for Akatsuki). And yes, I ran |
I have been using this on Q for since the PR was submitted... @jerpelea MERGE! |
CleanSpec: Clean system/vendor as well
CleanSpec: Fix copied headers path
Fix the removed path so that both
obj/
andobj_arm/
are cleared.This ensures that we do not make mistakes when porting away from
LOCAL_COPY_HEADERS
and get bitten when we finally get around to doing a clean build.treewide: Cleanup includes, include logic
subdirs
is deprecated and unnceeded in Q.Android.mk
: Organize for better readability, account for platforms namedsdm
in addition tomsm
.common_includes
.Remove reliance on COPY_HEADERS
LOCAL_COPY_HEADERS
is deprecated and will throw a build error in Android R.The header includes are duplicated anyway, the
display_headers
module already exports all necessary headers.sdm: Fix invalid string memory access
CAF doesn't get to decide what std version to use