[R] [8.1] No more COPY_HEADERS, default c++ std, CleanSpec, cleanups

[ix5]

CleanSpec: Clean system/vendor as well

CleanSpec: Fix copied headers path

Fix the removed path so that both obj/ and obj_arm/ are cleared.

This ensures that we do not make mistakes when porting away from LOCAL_COPY_HEADERS and get bitten when we finally get around to doing a clean build.

treewide: Cleanup includes, include logic

• Android.bp: subdirs is deprecated and unnceeded in Q.
• Top-level Android.mk: Organize for better readability, account for platforms named sdm in addition to msm.
• Treewide: Remove empty common_includes.

Remove reliance on COPY_HEADERS

LOCAL_COPY_HEADERS is deprecated and will throw a build error in Android R.

The header includes are duplicated anyway, the display_headers module already exports all necessary headers.

sdm: Fix invalid string memory access

CAF doesn't get to decide what std version to use

[oshmoun]

0d48278
not sure I understand how this changes anything

[MarijnS95]

@oshmoun For completeness let me write the explanation here too :)

char * is just a pointer to some memory, std::string is a string object that owns that piece of memory. Getting a pointer to that piece of memory (.c_str()) and then destroying the std::string (because it goes out of scope) means that memory is freed and .c_str() now points to invalid memory. The string may still be there, it may be garbage, or the entire page it's in might be reclaimed resulting in a nice segfault.

The correct way is to only ever return pointers to static readonly strings (eg. a character literal like "foo") or the managed std::string, which is what happens here. .c_str() is only taken and used while backing memory is still in scope.

[MarijnS95]

Also, this seems to build totally fine on Q too (for Akatsuki). And yes, I ran rm out/target/product/*/obj/include/ -r this time 😉.

[MarijnS95]

I have been using this on Q for since the PR was submitted... @jerpelea MERGE!