[2.3.2.r1.4] dts: tone: Set sound gpio to low by default#1938
Merged
jerpelea merged 1 commit intoMar 19, 2019
Conversation
The "output-high" setting in "pm8994_gpio_13: hph0_enable" in msm8996-mtp.dtsi needs to be overwritten since the GPIO should be disabled by default and only switched on for call sounds. This commit fixes the bug that the top speaker was only initialized after switching to call audio had force-toggled the GPIO.
Contributor
|
@kholk pinctrl |
Contributor
|
Well it should've been inherited from MTP with these parameters already, but apparently, at this point, I've missed some spaghetti style override that crapped it. Yeah that change looks valid. |
ix5
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
output-highsetting in pm8994_gpio_13: hph0_enable in msm8996-mtp.dtsi needs to be overwritten since the GPIO should be disabled by default and only switched on for call sounds.This commit fixes the bug that the top speaker was only initialized after switching to call audio had force-toggled the GPIO.