Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[2.3.2.r1.4] dts: tone: Set sound gpio to low by default #1938

Merged
merged 1 commit into from Mar 19, 2019

Conversation

ix5
Copy link

@ix5 ix5 commented Mar 18, 2019

The output-high setting in pm8994_gpio_13: hph0_enable in msm8996-mtp.dtsi needs to be overwritten since the GPIO should be disabled by default and only switched on for call sounds.

This commit fixes the bug that the top speaker was only initialized after switching to call audio had force-toggled the GPIO.

The "output-high" setting in "pm8994_gpio_13: hph0_enable" in
msm8996-mtp.dtsi needs to be overwritten since the GPIO should be
disabled by default and only switched on for call sounds.

This commit fixes the bug that the top speaker was only initialized
after switching to call audio had force-toggled the GPIO.
@oshmoun
Copy link

@oshmoun oshmoun commented Mar 18, 2019

@kholk pinctrl

@kholk
Copy link
Contributor

@kholk kholk commented Mar 19, 2019

Well it should've been inherited from MTP with these parameters already, but apparently, at this point, I've missed some spaghetti style override that crapped it.

Yeah that change looks valid.
MERGE!

@jerpelea jerpelea merged commit f65921a into sonyxperiadev:aosp/LE.UM.2.3.2.r1.4 Mar 19, 2019
@ix5 ix5 deleted the tone-sound-gpio branch Mar 19, 2019
@ix5 ix5 changed the title [WIP] dts: tone: Set sound gpio to low by default [2.3.2.r1.4] dts: tone: Set sound gpio to low by default Feb 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants