Skip to content

[7.1.r1] arm64: vdso32: Use full path to Clang instead of relying on PATH #2380

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 2, 2021

Conversation

ix5
Copy link

@ix5 ix5 commented Jan 27, 2021

Using (cc-name) directly leads to selection of first (cc-name) in path without respecting (CC) - in practice, this means a fallback to host clang under /usr/bin/clang.

32-bit cross compilers will still be respected.

**EDIT: ** Apparently Nathan already fixed this and it was not ported over: FROMLIST: arm64: vdso32: Use full path to Clang instead of relying on PATH

Copy link
Contributor

@Haxk20 Haxk20 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have nothing to nitpick or change here. LGTM

… PATH

Currently, in order to build the compat VDSO with Clang, this format
has to be used:

  PATH=${BIN_FOLDER}:${PATH} make CC=clang

Prior to the addition of this file, this format would also be
acceptable:

  make CC=${BIN_FOLDER}/clang

This is because the vdso32 Makefile uses cc-name instead of CC. After
this path, CC will still evaluate to clang for the first case as
expected but now the second case will use the specified Clang, rather
than the host's copy, which may not be compatible as shown below.

/usr/bin/as: unrecognized option '-mfloat-abi=soft'
clang-6.0: error: assembler command failed with exit code 1

Signed-off-by: Nathan Chancellor <natechancellor@gmail.com>
(cherry picked from https://patchwork.kernel.org/patch/10419665)
Bug: 80184372
Change-Id: If90a5a4edbc2b5883b4c78161081ebeafbebdcde
@ix5 ix5 force-pushed the 71r1-vdso-clang branch from 5983780 to e7e48c0 Compare January 28, 2021 07:11
@ix5 ix5 changed the title [DONOTMERGE] [7.1.r1] arm64: vdso32: Use CC instead of cc-name [DONOTMERGE] [7.1.r1] arm64: vdso32: Use full path to Clang instead of relying on PATH Jan 28, 2021
@ix5 ix5 changed the title [DONOTMERGE] [7.1.r1] arm64: vdso32: Use full path to Clang instead of relying on PATH [7.1.r1] arm64: vdso32: Use full path to Clang instead of relying on PATH Jan 31, 2021
@jerpelea jerpelea merged commit 3dd79f5 into sonyxperiadev:aosp/LA.UM.7.1.r1 Feb 2, 2021
@ix5 ix5 deleted the 71r1-vdso-clang branch February 2, 2021 08:05
@ix5 ix5 restored the 71r1-vdso-clang branch April 5, 2023 02:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants