This repository was archived by the owner on Apr 7, 2026. It is now read-only.
ExtendedSettings: Declare as PROPRIETARY_MODULE#42
Merged
Conversation
Declaring LOCAL_PROPRIETARY_MODULE means ExtendedSettings.apk will get installed to /vendor/priv-app instead of /system/priv-app, making it compatible with Treble ROMs. Change-Id: Ie4f7f66117d40e6b0ba003b8c57f2b65def865de
ix5
changed the title
Contributor
Author
|
Just a reminder to myself and others, this change means we need to install the priv-app permissions xml to |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Declaring
LOCAL_PROPRIETARY_MODULEmeansExtendedSettings.apkwill get installed to/vendor/priv-appinstead of/system/priv-app, making it compatible with Treble ROMs.(Using PROPRIETARY instead of VENDOR for Nougat compatibility)