Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ExtendedSettings: Declare as PROPRIETARY_MODULE #42

Merged
merged 1 commit into from Feb 13, 2019
Merged

ExtendedSettings: Declare as PROPRIETARY_MODULE #42

merged 1 commit into from Feb 13, 2019

Conversation

ix5
Copy link
Contributor

@ix5 ix5 commented Jan 29, 2019

Declaring LOCAL_PROPRIETARY_MODULE means ExtendedSettings.apk will get installed to /vendor/priv-app instead of /system/priv-app, making it compatible with Treble ROMs.

(Using PROPRIETARY instead of VENDOR for Nougat compatibility)

Declaring LOCAL_PROPRIETARY_MODULE means ExtendedSettings.apk will get
installed to /vendor/priv-app instead of /system/priv-app, making it
compatible with Treble ROMs.

Change-Id: Ie4f7f66117d40e6b0ba003b8c57f2b65def865de
@ix5 ix5 changed the title ExtendedSettings: Declare as VENDOR_MODULE ExtendedSettings: Declare as PROPRIETARY_MODULE Jan 30, 2019
@ix5
Copy link
Contributor Author

ix5 commented Jan 31, 2019

Just a reminder to myself and others, this change means we need to install the priv-app permissions xml to $(TARGET_COPY_OUT_VENDOR)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants