[R] fwk-detect: Drop libnativehelper includes #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Modules are not supposed to include headers from outside their module directories directly, either rely on header-only libraries or rely on linked modules re-exporting them. Since only one macro is used from `JNIHelp.h`, just copy it here.
MarijnS95
approved these changes
Mar 29, 2020
There was a problem hiding this comment.
This is unfortunate, but I approve. It would have been nice to actually use the helpers from JNIhelp (like jniRegisterNativeMethods) but none of the libs are exported to vendor, and a macro like NELEMS is necessary regardless. Let's not waste too much time on CAF forks 😁
Build-tested on Q with m libvndfwk_detect_jni.qti, compiles successfully.
ix5
changed the title
|
@jerpelea click it |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Modules are not supposed to include headers from outside their module directories directly, either rely on header-only libraries or rely on linked modules re-exporting them.
Since only one macro is used from
JNIHelp.h, just copy it here.