Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[R] fwk-detect: Drop libnativehelper includes #3

Merged
merged 1 commit into from May 31, 2020

Conversation

ix5
Copy link
Contributor

@ix5 ix5 commented Mar 29, 2020

Modules are not supposed to include headers from outside their module directories directly, either rely on header-only libraries or rely on linked modules re-exporting them.

Since only one macro is used from JNIHelp.h, just copy it here.

Modules are not supposed to include headers from outside
their module directories directly, either rely on
header-only libraries or rely on linked modules re-exporting
them.

Since only one macro is used from `JNIHelp.h`, just copy it here.
Copy link
Contributor

@MarijnS95 MarijnS95 left a comment

This is unfortunate, but I approve. It would have been nice to actually use the helpers from JNIhelp (like jniRegisterNativeMethods) but none of the libs are exported to vendor, and a macro like NELEMS is necessary regardless. Let's not waste too much time on CAF forks 😁

Build-tested on Q with m libvndfwk_detect_jni.qti, compiles successfully.

@ix5 ix5 marked this pull request as ready for review Apr 10, 2020
@ix5 ix5 changed the title [WIP] [R] fwk-detect: Drop libnativehelper includes [R] fwk-detect: Drop libnativehelper includes Apr 10, 2020
@ix5
Copy link
Contributor Author

@ix5 ix5 commented May 29, 2020

@jerpelea click it

@jerpelea jerpelea merged commit d82ed8a into sonyxperiadev:aosp/LA.UM.8.1.r1 May 31, 2020
@ix5 ix5 deleted the 8.1-r-compat branch May 31, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants