Feature/insert on edge #583
Merged
Conversation
|
The code change seems reasonable. However, please add Javadoc comments for your new methods. Otherwise, it's really hard for the user to understand what they do. Btw, I appreciate the comments inside the method. They are really good. |
|
@StevenArzt Thank you for your feedback. I added Javadoc comments to the methods. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
insertOnEdge(toInsert, source, target)adds instrumentation in a manner such that the resulting CFG of the program will containtoInserton an edge that is defined bysourceandtarget.