Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

find_updates: return in ALL the appropriate failure cases #2052

Merged
merged 1 commit into from Apr 30, 2021
Merged

find_updates: return in ALL the appropriate failure cases #2052

merged 1 commit into from Apr 30, 2021

Conversation

dgw
Copy link
Member

@dgw dgw commented Apr 3, 2021

Description

Even if there haven't been enough check failures to trigger a warning to Sopel's owner, it still needs to skip trying to print the info about whatever new release is available because that variable doesn't exist.

Missed in #1779 / 951fcca, oops.

Checklist

  • I have read CONTRIBUTING.md
  • I can and do license this contribution under the EFLv2
  • No issues are reported by make qa (runs make quality and make test)
  • I have tested the functionality of the things this change touches (see Notes)

Notes

Relying on reporter (@RhinosF1) to see if the bug is still reproducible with this patch.

@dgw
find_updates: return in ALL the appropriate failure cases
8dbce96 
Even if there haven't been enough check failures to trigger a warning to
Sopel's owner, it still needs to skip trying to print the `info` about
whatever new release is available because that variable doesn't exist.

Fixes #2051.

Missed in #1779 / 951fcca, oops.
@dgw dgw added the Bugfix Generally, PRs that reference (and fix) one or more issue(s) label Apr 3, 2021
@dgw dgw added this to the 7.1.0 milestone Apr 3, 2021
@dgw dgw requested a review from a team April 3, 2021 05:35
@dgw dgw linked an issue Apr 3, 2021 that may be closed by this pull request
find_updates: Unexpected error (local variable 'info' referenced before assignment) #2051
Closed
RhinosF1
RhinosF1 approved these changes Apr 3, 2021
View reviewed changes
Copy link
Contributor

@RhinosF1 RhinosF1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense to me, will let you know if this reoccurs after I deploy it.

@RhinosF1
Copy link
Contributor

RhinosF1 commented Apr 3, 2021

Makes sense to me, will let you know if this reoccurs after I deploy it.

Deployed!

@dgw
Copy link
Member Author

dgw commented Apr 29, 2021

Makes sense to me, will let you know if this reoccurs after I deploy it.

No news is good news?

@dgw
Copy link
Member Author

dgw commented Apr 30, 2021

Taking the below IRC quote as a vote of confidence, nothing more. PR coming soon with test case to verify new behavior. (Not adding directly to this PR because of dependency considerations to be discussed.)

14:29:12 <RhinosF1> dgw: haven't seen any occurence
14:29:58 <RhinosF1> Not that I'd also ever seen it prior to then either

@dgw dgw merged commit ed2b825 into master Apr 30, 2021
@dgw dgw deleted the find_updates-UnboundLocalError branch April 30, 2021 02:29
@dgw dgw mentioned this pull request Apr 30, 2021
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Exirel Exirel Exirel approved these changes

@RhinosF1 RhinosF1 RhinosF1 approved these changes

Assignees
No one assigned
Labels
Bugfix Generally, PRs that reference (and fix) one or more issue(s)
Projects
None yet
Milestone
7.1.0
Development

Successfully merging this pull request may close these issues.

find_updates: Unexpected error (local variable 'info' referenced before assignment)
3 participants
@dgw @RhinosF1 @Exirel