Feature/change nodes #266
Merged
Feature/change nodes #266
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
valentunn
commented
May 12, 2021
valentunn
commented
- Move active node tracking from prefs to db
- Add default node change generic migration
- Using migration above, change default nodes (remove web3, add Patract and onFinality)
FrogTravel
reviewed
May 13, 2021
|
|
||
| @Database( | ||
| version = 18, | ||
| version = 20, |
There was a problem hiding this comment.
Why we miss 19 version?
There was a problem hiding this comment.
Because there are two migrations in PR - first one from 18 to 19, and second one from 19 to 20
FrogTravel
reviewed
May 13, 2021
| } | ||
|
|
||
| @Suppress("ClassName") | ||
| class MoveActiveNodeTrackingToDb_18_19(private val migrator: PrefsToDbActiveNodeMigrator) : Migration(18, 19) { |
There was a problem hiding this comment.
And here we have migration from 18 to 19, but in another file we have version 20. Can you please help me with understanding why it is so? 🙃
There was a problem hiding this comment.
In this PR i, in general, did two things:
- Move active node from prefs to DB
- Change default node set
I decided to do them in separate migration for readability and easier understanding of migrations. That's why there are 18 -> 19 and 19 -> 20 migrations
FrogTravel
approved these changes
May 13, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.