From e602c6ae348c74e21896463970d43153c2f3a322 Mon Sep 17 00:00:00 2001 From: Nikita-Polyakov Date: Tue, 1 Jun 2021 16:06:34 +0300 Subject: [PATCH 1/3] neu styles & props improvement --- src/components/Button/SButton.vue | 12 +++++++++--- src/components/Input/SFloatInput.vue | 6 +++++- src/components/Input/SInput.vue | 3 +++ src/stories/SButton.stories.ts | 14 ++++++++++---- src/stories/SFloatInput.stories.ts | 19 ++++++++++++++++++- src/styles/neumorphism/button.scss | 22 ++++++++++++++++++++++ src/styles/neumorphism/variables.scss | 9 +++++++++ 7 files changed, 76 insertions(+), 9 deletions(-) diff --git a/src/components/Button/SButton.vue b/src/components/Button/SButton.vue index b4d15841..0620cc6a 100644 --- a/src/components/Button/SButton.vue +++ b/src/components/Button/SButton.vue @@ -9,7 +9,7 @@ :disabled="disabled" :loading="isLoading" :autofocus="autofocus" - :circle="type === ButtonTypes.ACTION && rounded" + :circle="isRounded" :icon="elementIcon" @click="handleClick" > @@ -134,7 +134,7 @@ export default class SButton extends Mixins(SizeMixin, BorderRadiusMixin, Design if ((Object.values(ButtonTypes) as Array).includes(this.type)) { cssClasses.push(`s-${this.type}`) } - if ((Object.values(ButtonIconPosition) as Array).includes(this.iconPosition)) { + if (!!this.availableIcon && (Object.values(ButtonIconPosition) as Array).includes(this.iconPosition)) { cssClasses.push(`s-i-position-${this.iconPosition}`) } if (this.isLoading) { @@ -169,8 +169,14 @@ export default class SButton extends Mixins(SizeMixin, BorderRadiusMixin, Design return this.icon } + get isRounded (): boolean { + if (this.type === ButtonTypes.LINK) return false + + return this.rounded + } + get isLoading (): boolean { - if (([ButtonTypes.LINK, ButtonTypes.ACTION] as Array).includes(this.type)) { + if (([ButtonTypes.LINK, ButtonTypes.ACTION] as Array).includes(this.type) || this.isRounded) { return false } return this.loading diff --git a/src/components/Input/SFloatInput.vue b/src/components/Input/SFloatInput.vue index 5667791a..e4aab325 100644 --- a/src/components/Input/SFloatInput.vue +++ b/src/components/Input/SFloatInput.vue @@ -8,7 +8,11 @@ input: handleInput, blur: onBlur }" - /> + > + +