From 6634b5648cfbe4586401f88538bc17db9575b0c3 Mon Sep 17 00:00:00 2001 From: Jake Zimmerman Date: Mon, 20 May 2019 17:16:35 -0700 Subject: [PATCH] Test in CI --- .buildkite/release-static.sh | 1 + .buildkite/test-and-build-ruby-runtime.sh | 3 +++ gems/sorbet/Rakefile | 5 ++++- 3 files changed, 8 insertions(+), 1 deletion(-) diff --git a/.buildkite/release-static.sh b/.buildkite/release-static.sh index 8d2a64ac427..832ee207265 100755 --- a/.buildkite/release-static.sh +++ b/.buildkite/release-static.sh @@ -76,6 +76,7 @@ if [[ "mac" == "$platform" ]]; then rbenv exec gem install sorbet-*.gem rbenv exec bundle rbenv exec bundle exec rake test + test/snapshot/driver.sh rbenv exec gem uninstall --all --executables --ignore-dependencies sorbet sorbet-static fi popd diff --git a/.buildkite/test-and-build-ruby-runtime.sh b/.buildkite/test-and-build-ruby-runtime.sh index 7a387e47abd..4a4a5eae3e4 100644 --- a/.buildkite/test-and-build-ruby-runtime.sh +++ b/.buildkite/test-and-build-ruby-runtime.sh @@ -10,6 +10,9 @@ rbenv shell 2.4.3 rbenv exec bundle install --path vendor/bundle echo "+++ tests" +# TODO(jez) This only tests unit tests right now. +# It should also run snapshot tests, but the snapshot tests don't currently +# work with debug versions of Sorbet. rbenv exec bundle exec rake test echo "--- build" diff --git a/gems/sorbet/Rakefile b/gems/sorbet/Rakefile index 15eae9fddc8..450ff59d658 100644 --- a/gems/sorbet/Rakefile +++ b/gems/sorbet/Rakefile @@ -5,5 +5,8 @@ task :test do Dir.glob('./test/**/*.rb').reject {|f| f =~ /^\.\/test\/snapshot/}.each(&method(:require)) - system(["test/snapshot/driver.sh", "test/snapshot/driver.sh"]) || exit(1) + # TODO(jez) Testing the snapshot tests does not currently work with debug versions of Sorbet. + # To run the snapshot tests, we're currently running the driver directly, + # instead of indirectly through `rake test` so that we can still run unit tests. + # system(["test/snapshot/driver.sh", "test/snapshot/driver.sh"]) || exit(1) end