Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Various cleanups #912

Merged
merged 17 commits into from Jun 20, 2019
Merged

Various cleanups #912

merged 17 commits into from Jun 20, 2019

Conversation

DarkDimius
Copy link
Collaborator

@DarkDimius DarkDimius commented Jun 20, 2019

Motivation

First commit is the result of profiling.
All other commits are results of running clang-tidy.

Test plan

CI

@DarkDimius DarkDimius requested a review from jez June 20, 2019 04:20
Copy link
Collaborator

@jez jez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice. The atomic increment is because we copy the TypeAndOrigins, it has a field that wraps a shared_ptr, and shared_ptrs copies require atomic increments?

@DarkDimius
Copy link
Collaborator Author

The atomic increment is because we copy the TypeAndOrigins, it has a field that wraps a shared_ptr, and shared_ptrs copies require atomic increments?

yes, and because we've defined a destructor it removed move assignment operator.

@DarkDimius DarkDimius merged commit 96de5af into master Jun 20, 2019
@DarkDimius DarkDimius deleted the dp-cleanups branch June 20, 2019 17:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants