New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Various cleanups #912
Various cleanups #912
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice. The atomic increment is because we copy the TypeAndOrigins, it has a field that wraps a shared_ptr, and shared_ptrs copies require atomic increments?
yes, and because we've defined a destructor it removed move assignment operator. |
Motivation
First commit is the result of profiling.
All other commits are results of running clang-tidy.
Test plan
CI