Update js/cufon.js #223

Open
wants to merge 2 commits into
from

Conversation

Projects
None yet
1 participant
@Devolv

Devolv commented Dec 5, 2011

Update padding top when Device Ratio is greater than 1, padding is also multiplied by PixelRatio to prevent insufficient padding.

@Devolv

This comment has been minimized.

Show comment
Hide comment
@Devolv

Devolv Dec 5, 2011

This is in relation to previous issue: #222

With Retina devices - padding within the canvas elements are incorrect. Padding unit used within the Canvas element is pixels, and when using the device-pixel-ratio=2 doubles the padding as well, but this creates too much padding on the Retina devices. Text height alignment is off as well, so vertically centering Cufon text on a header consistently would be impossible for both Retina and Non-Retina devices. Characters such as "g", "j" etc are also being clipped off the edge of the canvas element.

Devolv commented Dec 5, 2011

This is in relation to previous issue: #222

With Retina devices - padding within the canvas elements are incorrect. Padding unit used within the Canvas element is pixels, and when using the device-pixel-ratio=2 doubles the padding as well, but this creates too much padding on the Retina devices. Text height alignment is off as well, so vertically centering Cufon text on a header consistently would be impossible for both Retina and Non-Retina devices. Characters such as "g", "j" etc are also being clipped off the edge of the canvas element.

@Devolv

This comment has been minimized.

Show comment
Hide comment
@Devolv

Devolv Dec 5, 2011

My patch seems to work a lot better, but there is still bottom padding that I could not remove.

Devolv commented Dec 5, 2011

My patch seems to work a lot better, but there is still bottom padding that I could not remove.

@Devolv

This comment has been minimized.

Show comment
Hide comment
@Devolv

Devolv Dec 5, 2011

Owner

Updated again. Above code is incorrect. Not divide, but multiply.
ff28728

So far no strange behavior with the corrected patch.

Owner

Devolv commented on 3d050c8 Dec 5, 2011

Updated again. Above code is incorrect. Not divide, but multiply.
ff28728

So far no strange behavior with the corrected patch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment